Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert: restore TypeError if no arguments #12843

Closed
wants to merge 1 commit into from
Closed

assert: restore TypeError if no arguments #12843

wants to merge 1 commit into from

Commits on May 5, 2017

  1. assert: restore TypeError if no arguments 

    In Node 7.x, calling `throw new assert.AssertionError()` resulted in a
TypeError.

In current master, the same call does not result in an error but, due to
the default option, it results in uninformative output ("undefined
undefined undefined").

This change removes the default argument, restoring a TypeError if there
is no argument. This also will restore our test coverage to 100%. (The
default argument is not tested in our current test suite.)
    @Trott
    Trott committed May 5, 2017
    Configuration menu
    Copy the full SHA
    078ff1c View commit details
    Browse the repository at this point in the history