Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add override to ServerDone function #13166

Closed
wants to merge 1 commit into from
Closed

test: add override to ServerDone function #13166

wants to merge 1 commit into from

Commits on May 23, 2017

  1. test: add override to ServerDone function 

    Currently the following compiler warning is displayed when building:
../test/cctest/test_inspector_socket_server.cc:142:8: warning:
'ServerDone' overrides a member function but is not marked 'override'
      [-Winconsistent-missing-override]
  void ServerDone() {
       ^
../src/inspector_socket_server.h:30:16: note: overridden virtual
function is here
  virtual void ServerDone() = 0;
               ^

This commit marks ServerDone with override to get rid of the warning.
    @danbev
    danbev committed May 23, 2017
    Configuration menu
    Copy the full SHA
    1ab7093 View commit details
    Browse the repository at this point in the history