Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add override to ServerDone function #13166

Closed
wants to merge 1 commit into from
Closed

test: add override to ServerDone function #13166

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented May 23, 2017

Currently the following compiler warning is displayed when building:

../test/cctest/test_inspector_socket_server.cc:142:8: warning:
'ServerDone' overrides a member function but is not marked 'override'
      [-Winconsistent-missing-override]
  void ServerDone() {
       ^
../src/inspector_socket_server.h:30:16: note: overridden virtual
function is here
  virtual void ServerDone() = 0;
               ^

This commit marks ServerDone with override to get rid of the warning.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@danbev
test: add override to ServerDone function
1ab7093 
Currently the following compiler warning is displayed when building:
../test/cctest/test_inspector_socket_server.cc:142:8: warning:
'ServerDone' overrides a member function but is not marked 'override'
      [-Winconsistent-missing-override]
  void ServerDone() {
       ^
../src/inspector_socket_server.h:30:16: note: overridden virtual
function is here
  virtual void ServerDone() = 0;
               ^

This commit marks ServerDone with override to get rid of the warning.
@nodejs-github-bot nodejs-github-bot added dont-land-on-v4.x inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests. labels May 23, 2017
@danbev
Copy link
Contributor Author

danbev commented May 23, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/8243/

@addaleax
Copy link
Member

Landed in 25ade76

@addaleax addaleax closed this May 25, 2017
addaleax pushed a commit that referenced this pull request May 25, 2017
@danbev @addaleax
test: add override to ServerDone function
25ade76 
Currently the following compiler warning is displayed when building:

  ../test/cctest/test_inspector_socket_server.cc:142:8: warning:
  'ServerDone' overrides a member function but is not marked 'override'
        [-Winconsistent-missing-override]
    void ServerDone() {
         ^
  ../src/inspector_socket_server.h:30:16: note: overridden virtual
  function is here
    virtual void ServerDone() = 0;
                 ^

This commit marks ServerDone with override to get rid of the warning.

PR-URL: #13166
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
jasnell pushed a commit that referenced this pull request May 25, 2017
@danbev @jasnell
test: add override to ServerDone function
443f12d 
Currently the following compiler warning is displayed when building:

  ../test/cctest/test_inspector_socket_server.cc:142:8: warning:
  'ServerDone' overrides a member function but is not marked 'override'
        [-Winconsistent-missing-override]
    void ServerDone() {
         ^
  ../src/inspector_socket_server.h:30:16: note: overridden virtual
  function is here
    virtual void ServerDone() = 0;
                 ^

This commit marks ServerDone with override to get rid of the warning.

PR-URL: #13166
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
jasnell pushed a commit that referenced this pull request May 28, 2017
@danbev @jasnell
test: add override to ServerDone function
b781fa7 
Currently the following compiler warning is displayed when building:

  ../test/cctest/test_inspector_socket_server.cc:142:8: warning:
  'ServerDone' overrides a member function but is not marked 'override'
        [-Winconsistent-missing-override]
    void ServerDone() {
         ^
  ../src/inspector_socket_server.h:30:16: note: overridden virtual
  function is here
    virtual void ServerDone() = 0;
                 ^

This commit marks ServerDone with override to get rid of the warning.

PR-URL: #13166
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@jasnell jasnell mentioned this pull request May 28, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
@danbev danbev deleted the serverdone-override branch June 28, 2017 05:41
@MylesBorins
Copy link
Contributor

This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported

@aliscco aliscco mentioned this pull request Apr 27, 2023
Open
@leonardoadame leonardoadame mentioned this pull request Nov 30, 2023
Open
@aliscco aliscco mentioned this pull request Dec 1, 2023
Open
This was referenced Dec 1, 2023
Open
Open
Open
Open
@aliscco aliscco mentioned this pull request Dec 2, 2023
Open
@leonardoadame leonardoadame mentioned this pull request Dec 3, 2023
Open
This was referenced May 14, 2024
Open
Open
@aliscco aliscco mentioned this pull request May 15, 2024
Open
This was referenced May 16, 2024
Open
Open
@aliscco aliscco mentioned this pull request May 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@danbev @addaleax @MylesBorins @refack @jasnell @cjihrig @nodejs-github-bot