Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix out of date sections in n-api doc #13508

Closed
wants to merge 1 commit into from

Conversation

@mhdawson
Copy link
Member

@mhdawson mhdawson commented Jun 6, 2017

Fixes: #13469
Fixes: #13458

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows [commit guidelines]
Affected core subsystem(s)

doc, n-api

Fixes: #13469
Fixes: #13458
@cjihrig
cjihrig approved these changes Jun 6, 2017
@RReverser
Copy link
Member

@RReverser RReverser commented Jun 8, 2017

@mhdawson While you're on it, could you please take a look at #13469 (comment)?

@mhdawson
Copy link
Member Author

@mhdawson mhdawson commented Jun 8, 2017

@RReverser since this PR is past the 48 hour wait and has been reviewed, I'd prefer to cover that one in the next set of changes. From our discussion today in the N-API I think there are another 3-4 ones that you have found that I can cover together.

@mhdawson
Copy link
Member Author

@mhdawson mhdawson commented Jun 9, 2017

CI good landing.

@mhdawson
Copy link
Member Author

@mhdawson mhdawson commented Jun 9, 2017

Landed as c28418a

@mhdawson mhdawson closed this Jun 9, 2017
mhdawson added a commit that referenced this pull request Jun 9, 2017
PR-URL: #13508
Fixes: #13469
Fixes: #13458
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
addaleax added a commit that referenced this pull request Jun 10, 2017
PR-URL: #13508
Fixes: #13469
Fixes: #13458
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
@addaleax addaleax mentioned this pull request Jun 10, 2017
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
2 of 3 tasks complete
@mhdawson mhdawson deleted the mhdawson:napi-doc-misc1 branch Jun 28, 2017
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018
PR-URL: nodejs#13508
Fixes: nodejs#13469
Fixes: nodejs#13458
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
MylesBorins added a commit that referenced this pull request Apr 16, 2018
Backport-PR-URL: #19447
PR-URL: #13508
Fixes: #13469
Fixes: #13458
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants