New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix out of date sections in n-api doc #13508

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@mhdawson
Member

mhdawson commented Jun 6, 2017

Fixes: #13469
Fixes: #13458

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows [commit guidelines]
Affected core subsystem(s)

doc, n-api

@cjihrig

cjihrig approved these changes Jun 6, 2017

@RReverser

This comment has been minimized.

Member

RReverser commented Jun 8, 2017

@mhdawson While you're on it, could you please take a look at #13469 (comment)?

@mhdawson

This comment has been minimized.

Member

mhdawson commented Jun 8, 2017

@RReverser since this PR is past the 48 hour wait and has been reviewed, I'd prefer to cover that one in the next set of changes. From our discussion today in the N-API I think there are another 3-4 ones that you have found that I can cover together.

@mhdawson

This comment has been minimized.

Member

mhdawson commented Jun 8, 2017

@mhdawson

This comment has been minimized.

Member

mhdawson commented Jun 9, 2017

CI good landing.

@mhdawson

This comment has been minimized.

Member

mhdawson commented Jun 9, 2017

Landed as c28418a

@mhdawson mhdawson closed this Jun 9, 2017

mhdawson added a commit that referenced this pull request Jun 9, 2017

doc: fix out of date sections in n-api doc
PR-URL: #13508
Fixes: #13469
Fixes: #13458
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>

addaleax added a commit that referenced this pull request Jun 10, 2017

doc: fix out of date sections in n-api doc
PR-URL: #13508
Fixes: #13469
Fixes: #13458
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>

@addaleax addaleax referenced this pull request Jun 10, 2017

Merged

v8.1.1 proposal #13598

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete

@mhdawson mhdawson deleted the mhdawson:napi-doc-misc1 branch Jun 28, 2017

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Mar 12, 2018

doc: fix out of date sections in n-api doc
PR-URL: nodejs#13508
Fixes: nodejs#13469
Fixes: nodejs#13458
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Mar 15, 2018

doc: fix out of date sections in n-api doc
PR-URL: nodejs#13508
Fixes: nodejs#13469
Fixes: nodejs#13458
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Mar 31, 2018

doc: fix out of date sections in n-api doc
PR-URL: nodejs#13508
Fixes: nodejs#13469
Fixes: nodejs#13458
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Apr 6, 2018

doc: fix out of date sections in n-api doc
PR-URL: nodejs#13508
Fixes: nodejs#13469
Fixes: nodejs#13458
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018

doc: fix out of date sections in n-api doc
PR-URL: nodejs#13508
Fixes: nodejs#13469
Fixes: nodejs#13458
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>

MylesBorins added a commit that referenced this pull request Apr 16, 2018

doc: fix out of date sections in n-api doc
Backport-PR-URL: #19447
PR-URL: #13508
Fixes: #13469
Fixes: #13458
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>

@MylesBorins MylesBorins referenced this pull request Apr 16, 2018

Merged

v6.14.2 proposal #19996

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment