Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: check zlib version for createDeflateRaw #13697

Closed
wants to merge 6 commits into from
Closed

test: check zlib version for createDeflateRaw #13697

wants to merge 6 commits into from

Commits on Jun 15, 2017

  1. test: check zlib version for createDeflateRaw 

    We are currenly builing Node with --shared-zlib which happens to be
version 1.2.8. The test for zlib.createDeflateRaw is expected to fail
but does not when using version 1.2.8.

As far as I can tell the fix referred to in the comments was
introduced in version 1.2.9:
- Reject a window size of 256 bytes if not using the zlib wrapper

This commit suggests adding a check for the version and skipping this
assert if the version is less than 1.2.9.

Refs: http://zlib.net/ChangeLog.txt
    @danbev
    danbev committed Jun 15, 2017
    Copy the full SHA
    6db35e8 View commit details
    Browse the repository at this point in the history

  2. add comment about the version check

    @danbev
    danbev committed Jun 15, 2017
    Copy the full SHA
    7e61bcf View commit details
    Browse the repository at this point in the history

  3. use test() instead of match()

    @danbev
    danbev committed Jun 15, 2017
    Copy the full SHA
    a6365bf View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2017

  1. update regex to check for invalid version

    @danbev
    danbev committed Jun 16, 2017
    Copy the full SHA
    b9833a1 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2017

  1. simplify regex

    @danbev
    danbev committed Jun 18, 2017
    Copy the full SHA
    aa525e4 View commit details
    Browse the repository at this point in the history

  2. fix spelling of version

    @danbev
    danbev committed Jun 18, 2017
    Copy the full SHA
    1441b21 View commit details
    Browse the repository at this point in the history