New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: split up cpplint to avoid long cmd lines #14116

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@kfarnung
Member

kfarnung commented Jul 6, 2017

Refactors cpplint slightly to allow multiple runs of it. This allows
downstream projects to run cpplint on their dependencies.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

build: split up cpplint to avoid long cmd lines
Refactors cpplint slightly to allow multiple runs of it. This allows
downstream projects to run cpplint on their dependencies.
@kfarnung

This comment has been minimized.

Show comment
Hide comment
@kfarnung
Member

kfarnung commented Jul 6, 2017

/cc @refack

Upstream port of nodejs/node-chakracore#330

@kfarnung kfarnung referenced this pull request Jul 6, 2017

Merged

build: split up cpplint to avoid long cmd lines #330

2 of 2 tasks complete
@refack

refack approved these changes Jul 6, 2017

@refack

This comment has been minimized.

Show comment
Hide comment
@joaocgreis

LGTM, I confirmed that this is runs the same commands as before.

@joaocgreis

This comment has been minimized.

Show comment
Hide comment
@joaocgreis

joaocgreis Jul 9, 2017

Member

CI: https://ci.nodejs.org/view/All/job/node-test-pull-request/9048/ (I don't see a way for failures outside test-windows to be related, but every PR must have a full CI run)

Member

joaocgreis commented Jul 9, 2017

CI: https://ci.nodejs.org/view/All/job/node-test-pull-request/9048/ (I don't see a way for failures outside test-windows to be related, but every PR must have a full CI run)

refack added a commit to refack/node that referenced this pull request Jul 9, 2017

build: split up cpplint to avoid long cmd lines
Refactors cpplint slightly to allow multiple runs of it. This allows
downstream projects to run cpplint on their dependencies.

PR-URL: nodejs#14116
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com>
Reviewed-By: João Reis <reis@janeasystems.com>
@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack Jul 9, 2017

Member

Landed in d48472c

Member

refack commented Jul 9, 2017

Landed in d48472c

@refack refack closed this Jul 9, 2017

@refack

This comment has been minimized.

Show comment
Hide comment
@refack
Member

refack commented Jul 9, 2017

addaleax added a commit that referenced this pull request Jul 11, 2017

build: split up cpplint to avoid long cmd lines
Refactors cpplint slightly to allow multiple runs of it. This allows
downstream projects to run cpplint on their dependencies.

PR-URL: #14116
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com>
Reviewed-By: João Reis <reis@janeasystems.com>

@addaleax addaleax referenced this pull request Jul 11, 2017

Merged

v8.2.0 proposal #13744

@kfarnung kfarnung deleted the kfarnung:cpplint branch Jul 12, 2017

addaleax added a commit that referenced this pull request Jul 18, 2017

build: split up cpplint to avoid long cmd lines
Refactors cpplint slightly to allow multiple runs of it. This allows
downstream projects to run cpplint on their dependencies.

PR-URL: #14116
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com>
Reviewed-By: João Reis <reis@janeasystems.com>

Fishrock123 added a commit that referenced this pull request Jul 19, 2017

build: split up cpplint to avoid long cmd lines
Refactors cpplint slightly to allow multiple runs of it. This allows
downstream projects to run cpplint on their dependencies.

PR-URL: #14116
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com>
Reviewed-By: João Reis <reis@janeasystems.com>
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Aug 16, 2017

Member

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the dont-land-on label.

Member

MylesBorins commented Aug 16, 2017

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the dont-land-on label.

@kfarnung

This comment has been minimized.

Show comment
Hide comment
@kfarnung

kfarnung Aug 16, 2017

Member

@MylesBorins this should not be needed downlevel. The fix was primarily to allow deps (in this case chakrashim) to be able to have their own lint run without exceeding the Windows command line limit.

@refack do you agree?

Member

kfarnung commented Aug 16, 2017

@MylesBorins this should not be needed downlevel. The fix was primarily to allow deps (in this case chakrashim) to be able to have their own lint run without exceeding the Windows command line limit.

@refack do you agree?

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack Aug 16, 2017

Member

Not needed but harmless to backport and even a tiny bit beneficial, if only to reduce disparity between the versions.
@kfarnung if you don't have the spare cycles, I'll do it.

Member

refack commented Aug 16, 2017

Not needed but harmless to backport and even a tiny bit beneficial, if only to reduce disparity between the versions.
@kfarnung if you don't have the spare cycles, I'll do it.

@kfarnung

This comment has been minimized.

Show comment
Hide comment
@kfarnung

kfarnung Aug 16, 2017

Member

I'll take care of it today.

Member

kfarnung commented Aug 16, 2017

I'll take care of it today.

kfarnung added a commit to kfarnung/node that referenced this pull request Aug 16, 2017

build: split up cpplint to avoid long cmd lines
Refactors cpplint slightly to allow multiple runs of it. This allows
downstream projects to run cpplint on their dependencies.

PR-URL: nodejs#14116
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com>
Reviewed-By: João Reis <reis@janeasystems.com>

@kfarnung kfarnung referenced this pull request Aug 16, 2017

Closed

[v6.x backport] build: enable cpplint on windows #14879

2 of 2 tasks complete

MylesBorins added a commit that referenced this pull request Sep 19, 2017

build: split up cpplint to avoid long cmd lines
Refactors cpplint slightly to allow multiple runs of it. This allows
downstream projects to run cpplint on their dependencies.

Backport-PR-URL: #14879
PR-URL: #14116
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com>
Reviewed-By: João Reis <reis@janeasystems.com>

@MylesBorins MylesBorins referenced this pull request Sep 20, 2017

Merged

v6.11.4 proposal #15506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment