Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: replace assert-throw-arguments custom lint #14547

Closed
wants to merge 1 commit into from
Closed

tools: replace assert-throw-arguments custom lint #14547

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 30, 2017 •
edited
Loading

The functionality of ESLint custom rule assert-throws-arguments can be
replaced with no-restricted-syntax entries.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

@Trott
tools: replace assert-throw-arguments custom lint
ba3683e 
The functionality of ESLint custom rule assert-throws-arguments can be
replaced with no-restricted-syntax entries.
@Trott Trott added the tools Issues and PRs related to the tools directory. label Jul 30, 2017
@Trott
Copy link
Member Author

Trott commented Jul 31, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/9415/

TimothyGu
TimothyGu approved these changes Jul 31, 2017
View reviewed changes
Copy link
Member

@TimothyGu TimothyGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint is amazing.

@Trott
Copy link
Member Author

Trott commented Aug 2, 2017

Landed in e506bcd

@Trott Trott closed this Aug 2, 2017
Trott added a commit to Trott/io.js that referenced this pull request Aug 2, 2017
@Trott
tools: replace assert-throw-arguments custom lint
e506bcd 
The functionality of ESLint custom rule assert-throws-arguments can be
replaced with no-restricted-syntax entries.

PR-URL: nodejs#14547
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Aug 7, 2017
@Trott @addaleax
tools: replace assert-throw-arguments custom lint
9f319d5 
The functionality of ESLint custom rule assert-throws-arguments can be
replaced with no-restricted-syntax entries.

PR-URL: #14547
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins
Copy link
Contributor

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the dont-land-on label.

Trott added a commit to Trott/io.js that referenced this pull request Sep 7, 2017
@Trott
tools: replace assert-throw-arguments custom lint
2d0891e 
The functionality of ESLint custom rule assert-throws-arguments can be
replaced with no-restricted-syntax entries.

PR-URL: nodejs#14547
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott Trott mentioned this pull request Sep 7, 2017
Closed
4 tasks
@Trott
Copy link
Member Author

Trott commented Sep 7, 2017

@MylesBorins Backport in #15253

MylesBorins pushed a commit that referenced this pull request Sep 19, 2017
@Trott @MylesBorins
tools: replace assert-throw-arguments custom lint
f8b85e1 
The functionality of ESLint custom rule assert-throws-arguments can be
replaced with no-restricted-syntax entries.

Backport-PR-URL: #15253
PR-URL: #14547
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Sep 20, 2017
Merged
@Trott Trott deleted the no-restricted branch January 13, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @MylesBorins @jasnell @lpinca @TimothyGu @cjihrig @tniessen