New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix npm install with --shared #16438

Closed
wants to merge 1 commit into
base: master
from

Conversation

@bnoordhuis
Member

bnoordhuis commented Oct 24, 2017

The npm install rules had a hidden dependency on the node binary
install rule creating the $PREFIX/bin directory.

Because with ./configure --shared no binary is created, the rule
subsequently failed. Fix that by creating the directory before
creating the symlinks to the npm and npx scripts.

(Whether it makes sense to install npm without a node binary is
a separate question. This commit is not taking positions. :-))

Regression introduced in commit ed8c89a ("build: fix shared installing
target") which, as the commit log indicates, was itself a bug fix for
the ./configure --shared install.

Fixes: #16437
Refs: #15148

build: fix npm install with --shared
The npm install rules had a hidden dependency on the `node` binary
install rule creating the `$PREFIX/bin` directory.

Because with `./configure --shared` no binary is created, the rule
subsequently failed.  Fix that by creating the directory before
creating the symlinks to the npm and npx scripts.

(Whether it makes sense to install npm without a `node` binary is
a separate question.  This commit is not taking positions. :-))

Regression introduced in commit ed8c89a ("build: fix shared installing
target") which, as the commit log indicates, was itself a bug fix for
the `./configure --shared` install.

Fixes: #16437
Refs: #15148
@refack

refack approved these changes Oct 24, 2017

@refack refack added the python label Oct 24, 2017

@watilde watilde added the npm label Oct 24, 2017

@mhdawson

LGTM

@mhdawson

This comment has been minimized.

Show comment
Hide comment
Member

mhdawson commented Oct 24, 2017

@mhdawson

This comment has been minimized.

Show comment
Hide comment
@mhdawson

mhdawson Oct 25, 2017

Member

CI run good landing.

Member

mhdawson commented Oct 25, 2017

CI run good landing.

@mhdawson

This comment has been minimized.

Show comment
Hide comment
@mhdawson

mhdawson Oct 25, 2017

Member

Landed as e714c42

Member

mhdawson commented Oct 25, 2017

Landed as e714c42

@mhdawson mhdawson closed this Oct 25, 2017

mhdawson added a commit that referenced this pull request Oct 25, 2017

build: fix npm install with --shared
The npm install rules had a hidden dependency on the `node` binary
install rule creating the `$PREFIX/bin` directory.

Because with `./configure --shared` no binary is created, the rule
subsequently failed.  Fix that by creating the directory before
creating the symlinks to the npm and npx scripts.

(Whether it makes sense to install npm without a `node` binary is
a separate question.  This commit is not taking positions. :-))

Regression introduced in commit ed8c89a ("build: fix shared installing
target") which, as the commit log indicates, was itself a bug fix for
the `./configure --shared` install.

PR-URL: #16438
Fixes: #16437
Ref: #15148
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@mhdawson

This comment has been minimized.

Show comment
Hide comment
@mhdawson

mhdawson Oct 25, 2017

Member

Sorry just noticed this was not past the 2 day waiting period. I can back it out if there are objections.

Member

mhdawson commented Oct 25, 2017

Sorry just noticed this was not past the 2 day waiting period. I can back it out if there are objections.

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Oct 26, 2017

Member

with the number of signoffs, it should be fine.

Member

jasnell commented Oct 26, 2017

with the number of signoffs, it should be fine.

addaleax added a commit to ayojs/ayo that referenced this pull request Oct 26, 2017

build: fix npm install with --shared
The npm install rules had a hidden dependency on the `node` binary
install rule creating the `$PREFIX/bin` directory.

Because with `./configure --shared` no binary is created, the rule
subsequently failed.  Fix that by creating the directory before
creating the symlinks to the npm and npx scripts.

(Whether it makes sense to install npm without a `node` binary is
a separate question.  This commit is not taking positions. :-))

Regression introduced in commit ed8c89a ("build: fix shared installing
target") which, as the commit log indicates, was itself a bug fix for
the `./configure --shared` install.

PR-URL: nodejs/node#16438
Fixes: nodejs/node#16437
Ref: nodejs/node#15148
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

gibfahn added a commit that referenced this pull request Oct 30, 2017

build: fix npm install with --shared
The npm install rules had a hidden dependency on the `node` binary
install rule creating the `$PREFIX/bin` directory.

Because with `./configure --shared` no binary is created, the rule
subsequently failed.  Fix that by creating the directory before
creating the symlinks to the npm and npx scripts.

(Whether it makes sense to install npm without a `node` binary is
a separate question.  This commit is not taking positions. :-))

Regression introduced in commit ed8c89a ("build: fix shared installing
target") which, as the commit log indicates, was itself a bug fix for
the `./configure --shared` install.

PR-URL: #16438
Fixes: #16437
Ref: #15148
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

gibfahn added a commit that referenced this pull request Oct 30, 2017

build: fix npm install with --shared
The npm install rules had a hidden dependency on the `node` binary
install rule creating the `$PREFIX/bin` directory.

Because with `./configure --shared` no binary is created, the rule
subsequently failed.  Fix that by creating the directory before
creating the symlinks to the npm and npx scripts.

(Whether it makes sense to install npm without a `node` binary is
a separate question.  This commit is not taking positions. :-))

Regression introduced in commit ed8c89a ("build: fix shared installing
target") which, as the commit log indicates, was itself a bug fix for
the `./configure --shared` install.

PR-URL: #16438
Fixes: #16437
Ref: #15148
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

gibfahn added a commit that referenced this pull request Oct 30, 2017

build: fix npm install with --shared
The npm install rules had a hidden dependency on the `node` binary
install rule creating the `$PREFIX/bin` directory.

Because with `./configure --shared` no binary is created, the rule
subsequently failed.  Fix that by creating the directory before
creating the symlinks to the npm and npx scripts.

(Whether it makes sense to install npm without a `node` binary is
a separate question.  This commit is not taking positions. :-))

Regression introduced in commit ed8c89a ("build: fix shared installing
target") which, as the commit log indicates, was itself a bug fix for
the `./configure --shared` install.

PR-URL: #16438
Fixes: #16437
Ref: #15148
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

gibfahn added a commit that referenced this pull request Oct 31, 2017

build: fix npm install with --shared
The npm install rules had a hidden dependency on the `node` binary
install rule creating the `$PREFIX/bin` directory.

Because with `./configure --shared` no binary is created, the rule
subsequently failed.  Fix that by creating the directory before
creating the symlinks to the npm and npx scripts.

(Whether it makes sense to install npm without a `node` binary is
a separate question.  This commit is not taking positions. :-))

Regression introduced in commit ed8c89a ("build: fix shared installing
target") which, as the commit log indicates, was itself a bug fix for
the `./configure --shared` install.

PR-URL: #16438
Fixes: #16437
Ref: #15148
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

gibfahn added a commit that referenced this pull request Oct 31, 2017

2017-10-31, Version 8.9.0 'Carbon' (LTS) Release
This LTS release comes with 86 commits. This includes 30 that are
updates to lib/ or src/, 20 that are test related, 13 that are doc
related, 19 which are build / tools related, and 4 commits which are
updates to dependencies.

Notable Changes:

- **npm**:
  - update npm to 5.5.1 (Myles Borins)
  [#16509](#16509)
- **module**:
  - support custom paths to require.resolve() (cjihrig)
  [#16397](#16397)
  - fix extension lookups for top-level main (Guy Bedford)
  [#16526](#16526)
  - fix hook module CJS dependency loading (guybedford)
  [#16381](#16381)
- **util**:
  - graduate TextEncoder/TextDecoder, tests (James M Snell)
  [#15743](#15743)

- **build**:
  - fix npm install with --shared (Ben Noordhuis)
  [#16438](#16438)
- **child_process**:
  - fix memory leak in .fork() (Ben Noordhuis)
  [#15679](#15679)
- **deps**:
  - cherry-pick gc fixes from upstream V8 (Michaël Zasso)
  [#16490](#16490)
- **http2**:
  - fix stream reading resumption (Anatoli Papirovski)
  [#16580](#16580)
  - simplify mapToHeaders, stricter validation (Anatoli Papirovski)
  [#16575](#16575)
  - fix several timeout related issues (Anatoli Papirovski)
  [#16525](#16525)
  - adjust stream buffer size (Anatoli Papirovski)
  [#16445](#16445)
  - fix mapToHeaders() with single string value (Jinwoo Lee)
  [#16458](#16458)
  - do not allow socket manipulation (Anatoli Papirovski)
  [#16330](#16330)
- **lib**:
  - move _stream_wrap into internals (Anna Henningsen)
  [#16158](#16158)
  - setup IPC channel before console (Nikolai Vavilov)
  [#16562](#16562)
- **src**:
  - move handle properties to prototype (Ben Noordhuis)
  [#16482](#16482)
  - use V8 function to get Module Namespace (Bradley Farias)
  [#16261](#16261)
  - fix vm module for strict mode (Franziska Hinkelmann)
  [#16487](#16487)
  - destroy inspector agent before context (Ali Ijaz Sheikh)
  [#16472](#16472)

gibfahn added a commit that referenced this pull request Oct 31, 2017

2017-10-31, Version 8.9.0 'Carbon' (LTS) Release
This LTS release comes with 87 commits. This includes 30 that are
updates to lib/ or src/, 20 that are test related, 13 that are doc
related, 19 which are build / tools related, and 4 commits which are
updates to dependencies.

Notable Changes:

- **npm**:
  - update npm to 5.5.1 (Myles Borins)
  [#16509](#16509)
- **module**:
  - support custom paths to require.resolve() (cjihrig)
  [#16397](#16397)
  - fix extension lookups for top-level main (Guy Bedford)
  [#16526](#16526)
  - fix hook module CJS dependency loading (guybedford)
  [#16381](#16381)
- **util**:
  - graduate TextEncoder/TextDecoder, tests (James M Snell)
  [#15743](#15743)

- **build**:
  - fix npm install with --shared (Ben Noordhuis)
  [#16438](#16438)
- **child_process**:
  - fix memory leak in .fork() (Ben Noordhuis)
  [#15679](#15679)
- **deps**:
  - cherry-pick gc fixes from upstream V8 (Michaël Zasso)
  [#16490](#16490)
- **http2**:
  - fix stream reading resumption (Anatoli Papirovski)
  [#16580](#16580)
  - simplify mapToHeaders, stricter validation (Anatoli Papirovski)
  [#16575](#16575)
  - fix several timeout related issues (Anatoli Papirovski)
  [#16525](#16525)
  - adjust stream buffer size (Anatoli Papirovski)
  [#16445](#16445)
  - fix mapToHeaders() with single string value (Jinwoo Lee)
  [#16458](#16458)
  - do not allow socket manipulation (Anatoli Papirovski)
  [#16330](#16330)
- **lib**:
  - move _stream_wrap into internals (Anna Henningsen)
  [#16158](#16158)
  - setup IPC channel before console (Nikolai Vavilov)
  [#16562](#16562)
- **src**:
  - move handle properties to prototype (Ben Noordhuis)
  [#16482](#16482)
  - use V8 function to get Module Namespace (Bradley Farias)
  [#16261](#16261)
  - fix vm module for strict mode (Franziska Hinkelmann)
  [#16487](#16487)
  - destroy inspector agent before context (Ali Ijaz Sheikh)
  [#16472](#16472)

@gibfahn gibfahn referenced this pull request Oct 31, 2017

Merged

v8.9.0 proposal #16630

gibfahn added a commit that referenced this pull request Oct 31, 2017

2017-10-31, Version 8.9.0 'Carbon' (LTS) Release
This LTS release comes with 87 commits. This includes 30 that are
updates to lib/ or src/, 20 that are test related, 13 that are doc
related, 19 which are build / tools related, and 4 commits which are
updates to dependencies.

Notable Changes:

- **npm**:
  - update npm to 5.5.1 (Myles Borins)
  [#16509](#16509)
- **module**:
  - support custom paths to require.resolve() (cjihrig)
  [#16397](#16397)
  - fix extension lookups for top-level main (Guy Bedford)
  [#16526](#16526)
  - fix hook module CJS dependency loading (guybedford)
  [#16381](#16381)
- **util**:
  - graduate TextEncoder/TextDecoder, tests (James M Snell)
  [#15743](#15743)

- **build**:
  - fix npm install with --shared (Ben Noordhuis)
  [#16438](#16438)
- **child_process**:
  - fix memory leak in .fork() (Ben Noordhuis)
  [#15679](#15679)
- **deps**:
  - cherry-pick gc fixes from upstream V8 (Michaël Zasso)
  [#16490](#16490)
- **http2**:
  - fix stream reading resumption (Anatoli Papirovski)
  [#16580](#16580)
  - fix several timeout related issues (Anatoli Papirovski)
  [#16525](#16525)
  - fix mapToHeaders() with single string value (Jinwoo Lee)
  [#16458](#16458)
  - do not allow socket manipulation (Anatoli Papirovski)
  [#16330](#16330)
- **lib**:
  - move _stream_wrap into internals (Anna Henningsen)
  [#16158](#16158)
  - setup IPC channel before console (Nikolai Vavilov)
  [#16562](#16562)
- **src**:
  - move handle properties to prototype (Ben Noordhuis)
  [#16482](#16482)
  - use V8 function to get Module Namespace (Bradley Farias)
  [#16261](#16261)
  - fix vm module for strict mode (Franziska Hinkelmann)
  [#16487](#16487)
  - destroy inspector agent before context (Ali Ijaz Sheikh)
  [#16472](#16472)

gibfahn added a commit that referenced this pull request Oct 31, 2017

2017-10-31, Version 8.9.0 'Carbon' (LTS) Release
This LTS release comes with 87 commits. This includes 30 that are
updates to lib/ or src/, 20 that are test related, 13 that are doc
related, 19 which are build / tools related, and 4 commits which are
updates to dependencies.

Notable Changes:

- **npm**:
  - update npm to 5.5.1 (Myles Borins)
  [#16509](#16509)
- **module**:
  - support custom paths to require.resolve() (cjihrig)
  [#16397](#16397)
  - fix extension lookups for top-level main (Guy Bedford)
  [#16526](#16526)
  - fix hook module CJS dependency loading (guybedford)
  [#16381](#16381)
- **util**:
  - graduate TextEncoder/TextDecoder, tests (James M Snell)
  [#15743](#15743)

- **build**:
  - fix npm install with --shared (Ben Noordhuis)
  [#16438](#16438)
- **child_process**:
  - fix memory leak in .fork() (Ben Noordhuis)
  [#15679](#15679)
- **deps**:
  - cherry-pick gc fixes from upstream V8 (Michaël Zasso)
  [#16490](#16490)
- **http2**:
  - fix stream reading resumption (Anatoli Papirovski)
  [#16580](#16580)
  - fix several timeout related issues (Anatoli Papirovski)
  [#16525](#16525)
  - fix mapToHeaders() with single string value (Jinwoo Lee)
  [#16458](#16458)
  - do not allow socket manipulation (Anatoli Papirovski)
  [#16330](#16330)
- **lib**:
  - move _stream_wrap into internals (Anna Henningsen)
  [#16158](#16158)
  - setup IPC channel before console (Nikolai Vavilov)
  [#16562](#16562)
- **src**:
  - move handle properties to prototype (Ben Noordhuis)
  [#16482](#16482)
  - use V8 function to get Module Namespace (Bradley Farias)
  [#16261](#16261)
  - fix vm module for strict mode (Franziska Hinkelmann)
  [#16487](#16487)
  - destroy inspector agent before context (Ali Ijaz Sheikh)
  [#16472](#16472)

PR-URL: #16630

MylesBorins added a commit that referenced this pull request Nov 16, 2017

build: fix npm install with --shared
The npm install rules had a hidden dependency on the `node` binary
install rule creating the `$PREFIX/bin` directory.

Because with `./configure --shared` no binary is created, the rule
subsequently failed.  Fix that by creating the directory before
creating the symlinks to the npm and npx scripts.

(Whether it makes sense to install npm without a `node` binary is
a separate question.  This commit is not taking positions. :-))

Regression introduced in commit ed8c89a ("build: fix shared installing
target") which, as the commit log indicates, was itself a bug fix for
the `./configure --shared` install.

PR-URL: #16438
Fixes: #16437
Ref: #15148
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@MylesBorins MylesBorins referenced this pull request Nov 21, 2017

Merged

v6.12.1 proposal #17180

MylesBorins added a commit that referenced this pull request Nov 21, 2017

build: fix npm install with --shared
The npm install rules had a hidden dependency on the `node` binary
install rule creating the `$PREFIX/bin` directory.

Because with `./configure --shared` no binary is created, the rule
subsequently failed.  Fix that by creating the directory before
creating the symlinks to the npm and npx scripts.

(Whether it makes sense to install npm without a `node` binary is
a separate question.  This commit is not taking positions. :-))

Regression introduced in commit ed8c89a ("build: fix shared installing
target") which, as the commit log indicates, was itself a bug fix for
the `./configure --shared` install.

PR-URL: #16438
Fixes: #16437
Ref: #15148
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

MylesBorins added a commit that referenced this pull request Nov 28, 2017

build: fix npm install with --shared
The npm install rules had a hidden dependency on the `node` binary
install rule creating the `$PREFIX/bin` directory.

Because with `./configure --shared` no binary is created, the rule
subsequently failed.  Fix that by creating the directory before
creating the symlinks to the npm and npx scripts.

(Whether it makes sense to install npm without a `node` binary is
a separate question.  This commit is not taking positions. :-))

Regression introduced in commit ed8c89a ("build: fix shared installing
target") which, as the commit log indicates, was itself a bug fix for
the `./configure --shared` install.

PR-URL: #16438
Fixes: #16437
Ref: #15148
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

MylesBorins added a commit that referenced this pull request Nov 28, 2017

2017-12-05, Version 6.12.1 'Boron' (LTS)
Notable Changes:

* build:
  - fix npm install with --shared (Ben Noordhuis)
    #16438
* build:
  - building with python 3 is now supported (Emily Marigold Klassen)
    #16058
* src:
  - v8 options can be specified with either '\_' or '-' in NODE_OPTIONS
    (Sam Roberts) #14093

PR-URL: #17180

MylesBorins added a commit that referenced this pull request Dec 5, 2017

2017-12-05, Version 6.12.1 'Boron' (LTS)
Notable Changes:

* build:
  - fix npm install with --shared (Ben Noordhuis)
    #16438
* build:
  - building with python 3 is now supported (Emily Marigold Klassen)
    #16058
* src:
  - v8 options can be specified with either '\_' or '-' in NODE_OPTIONS
    (Sam Roberts) #14093

PR-URL: #17180

addaleax added a commit to ayojs/ayo that referenced this pull request Dec 7, 2017

build: fix npm install with --shared
The npm install rules had a hidden dependency on the `node` binary
install rule creating the `$PREFIX/bin` directory.

Because with `./configure --shared` no binary is created, the rule
subsequently failed.  Fix that by creating the directory before
creating the symlinks to the npm and npx scripts.

(Whether it makes sense to install npm without a `node` binary is
a separate question.  This commit is not taking positions. :-))

Regression introduced in commit ed8c89a ("build: fix shared installing
target") which, as the commit log indicates, was itself a bug fix for
the `./configure --shared` install.

PR-URL: nodejs/node#16438
Fixes: nodejs/node#16437
Ref: nodejs/node#15148
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

2017-12-05, Version 6.12.1 'Boron' (LTS)
Notable Changes:

* build:
  - fix npm install with --shared (Ben Noordhuis)
    nodejs#16438
* build:
  - building with python 3 is now supported (Emily Marigold Klassen)
    nodejs#16058
* src:
  - v8 options can be specified with either '\_' or '-' in NODE_OPTIONS
    (Sam Roberts) nodejs#14093

PR-URL: nodejs#17180

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

2017-12-05, Version 6.12.1 'Boron' (LTS)
Notable Changes:

* build:
  - fix npm install with --shared (Ben Noordhuis)
    nodejs#16438
* build:
  - building with python 3 is now supported (Emily Marigold Klassen)
    nodejs#16058
* src:
  - v8 options can be specified with either '\_' or '-' in NODE_OPTIONS
    (Sam Roberts) nodejs#14093

PR-URL: nodejs#17180
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment