Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix npm install with --shared #16438

Closed
wants to merge 1 commit into from
Closed

build: fix npm install with --shared #16438

wants to merge 1 commit into from

Commits on Oct 24, 2017

  1. build: fix npm install with --shared 

    The npm install rules had a hidden dependency on the `node` binary
install rule creating the `$PREFIX/bin` directory.

Because with `./configure --shared` no binary is created, the rule
subsequently failed.  Fix that by creating the directory before
creating the symlinks to the npm and npx scripts.

(Whether it makes sense to install npm without a `node` binary is
a separate question.  This commit is not taking positions. :-))

Regression introduced in commit ed8c89a ("build: fix shared installing
target") which, as the commit log indicates, was itself a bug fix for
the `./configure --shared` install.

Fixes: nodejs#16437
Refs: nodejs#15148
    @bnoordhuis
    bnoordhuis committed Oct 24, 2017
    Configuration menu
    Copy the full SHA
    12c8f22 View commit details
    Browse the repository at this point in the history