Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove cctest extension #16680

Closed
wants to merge 1 commit into from

Conversation

@yhwang
Copy link
Member

commented Nov 2, 2017

cctest appends so.59 when building node shared library in linux.
The appending is defined in node.gypi and the cctest target in node.gyp
includes node.gypi. Moving the appending from node.gypi to node target
in node.gyp fix the issue.

Signed-off-by: Yihong Wang yh.wang@ibm.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

@jasnell jasnell requested review from bnoordhuis and refack Nov 2, 2017

@gibfahn

This comment has been minimized.

Copy link
Member

commented Nov 2, 2017

@bnoordhuis
Copy link
Member

left a comment

@jasnell

jasnell approved these changes Nov 2, 2017

@refack refack self-assigned this Nov 2, 2017

@yhwang

This comment has been minimized.

Copy link
Member Author

commented Nov 2, 2017

despite of node-test-commit-arm-fanned, seems linux and plinux were failed in this test case: parallel/test-http2-server-rst-stream. Is it a intermittent failure recently?

@jasnell

This comment has been minimized.

Copy link
Member

commented Nov 2, 2017

That was a known flaky test. The fix just landed. It's unrelated to this pr

@yhwang yhwang force-pushed the yhwang:cctest-in-node-shared branch from f881e6a to 15be1b7 Nov 2, 2017

@yhwang

This comment has been minimized.

Copy link
Member Author

commented Nov 2, 2017

okay, found it : #16690. And it's landed. Can someone rerun the CI? Thanks.

@yhwang

This comment has been minimized.

Copy link
Member Author

commented Nov 2, 2017

thanks @jasnell then the failures on the CI above are from here https://ci.nodejs.org/job/node-test-binary-arm/11442/. is this critical and need to figure out? The run_subset 6 passed in all pi

@mhdawson
Copy link
Member

left a comment

LGTM

@mhdawson

This comment has been minimized.

Copy link
Member

commented Nov 2, 2017

@yhwang

This comment has been minimized.

Copy link
Member Author

commented Nov 2, 2017

still got some failures:

However, I think these are not related to my change.

@gibfahn

This comment has been minimized.

Copy link
Member

commented Nov 2, 2017

However, I think these are not related to my change.

Yep, you never need to worry about the flaky tests, and the Pi failures are known issues.

@cjihrig

cjihrig approved these changes Nov 2, 2017

@gibfahn

gibfahn approved these changes Nov 2, 2017

@danbev

danbev approved these changes Nov 3, 2017

@yhwang

This comment has been minimized.

Copy link
Member Author

commented Nov 7, 2017

Ping, Is there anything that I should do in order to get this to be landed?

build: remove cctest extension
cctest has `so.59` extension when building node shared library in linux.
The appending is defined in node.gypi and the cctest target in node.gyp
includes node.gypi. Moving the appending from node.gypi to node target
in node.gyp fixes the issue.

Signed-off-by: Yihong Wang <yh.wang@ibm.com>

@yhwang yhwang force-pushed the yhwang:cctest-in-node-shared branch from 15be1b7 to b167b28 Nov 10, 2017

@yhwang

This comment has been minimized.

Copy link
Member Author

commented Nov 10, 2017

Resolved the conflict and need a new CI. Thanks!

@refack

refack approved these changes Nov 10, 2017

@refack

This comment has been minimized.

Copy link
Member

commented Nov 10, 2017

@refack

This comment has been minimized.

Copy link
Member

commented Nov 10, 2017

Landed in b340c2d

@refack refack closed this Nov 10, 2017

refack added a commit to refack/node that referenced this pull request Nov 10, 2017

build: remove cctest extension
cctest has `so.59` extension when building node shared library in linux.
The appending is defined in node.gypi and the cctest target in node.gyp
includes node.gypi. Moving the appending from node.gypi to node target
in node.gyp fixes the issue.

Signed-off-by: Yihong Wang <yh.wang@ibm.com>

PR-URL: nodejs#16680
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@yhwang

This comment has been minimized.

Copy link
Member Author

commented Nov 10, 2017

thanks @refack

@yhwang yhwang deleted the yhwang:cctest-in-node-shared branch Nov 10, 2017

evanlucas added a commit that referenced this pull request Nov 13, 2017

build: remove cctest extension
cctest has `so.59` extension when building node shared library in linux.
The appending is defined in node.gypi and the cctest target in node.gyp
includes node.gypi. Moving the appending from node.gypi to node target
in node.gyp fixes the issue.

Signed-off-by: Yihong Wang <yh.wang@ibm.com>

PR-URL: #16680
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

@evanlucas evanlucas referenced this pull request Nov 13, 2017

Merged

v9.2.0 proposal #16992

@MylesBorins

This comment has been minimized.

Copy link
Member

commented Nov 17, 2017

Should this be backported to v6.x-staging or v8.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

@yhwang

This comment has been minimized.

Copy link
Member Author

commented Nov 17, 2017

@MylesBorins yes, it should be backported to v6.x-staging or v8.x-staging. I will follow the guide to do the backport. Thanks for the reminding.

yhwang added a commit to yhwang/node that referenced this pull request Nov 22, 2017

build: remove cctest extension
cctest has `so.59` extension when building node shared library in linux.
The appending is defined in node.gypi and the cctest target in node.gyp
includes node.gypi. Moving the appending from node.gypi to node target
in node.gyp fixes the issue.

Signed-off-by: Yihong Wang <yh.wang@ibm.com>

PR-URL: nodejs#16680
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

@yhwang yhwang referenced this pull request Nov 22, 2017

Closed

[v6.x backport] build: remove cctest extension #17255

2 of 2 tasks complete

yhwang added a commit to yhwang/node that referenced this pull request Nov 22, 2017

build: remove cctest extension
cctest has `so.59` extension when building node shared library in linux.
The appending is defined in node.gypi and the cctest target in node.gyp
includes node.gypi. Moving the appending from node.gypi to node target
in node.gyp fixes the issue.

Signed-off-by: Yihong Wang <yh.wang@ibm.com>

PR-URL: nodejs#16680
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

@yhwang yhwang referenced this pull request Nov 22, 2017

Closed

[v8.x backport] build: remove cctest extension #17258

2 of 2 tasks complete

MylesBorins added a commit that referenced this pull request Nov 28, 2017

build: remove cctest extension
cctest has `so.59` extension when building node shared library in linux.
The appending is defined in node.gypi and the cctest target in node.gyp
includes node.gypi. Moving the appending from node.gypi to node target
in node.gyp fixes the issue.

Signed-off-by: Yihong Wang <yh.wang@ibm.com>

Backport-PR-URL: #17255
PR-URL: #16680
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

@MylesBorins MylesBorins referenced this pull request Nov 28, 2017

Merged

v6.12.1 proposal #17180

yhwang added a commit to yhwang/node that referenced this pull request Dec 20, 2017

build: remove cctest extension
cctest has `so.59` extension when building node shared library in linux.
The appending is defined in node.gypi and the cctest target in node.gyp
includes node.gypi. Moving the appending from node.gypi to node target
in node.gyp fixes the issue.

Signed-off-by: Yihong Wang <yh.wang@ibm.com>

PR-URL: nodejs#16680
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

gibfahn added a commit that referenced this pull request Dec 20, 2017

build: remove cctest extension
cctest has `so.59` extension when building node shared library in linux.
The appending is defined in node.gypi and the cctest target in node.gyp
includes node.gypi. Moving the appending from node.gypi to node target
in node.gyp fixes the issue.

Signed-off-by: Yihong Wang <yh.wang@ibm.com>

PR-URL: #16680
Backport-PR-URL: #17258
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

gibfahn added a commit that referenced this pull request Jan 3, 2018

build: remove cctest extension
cctest has `so.59` extension when building node shared library in linux.
The appending is defined in node.gypi and the cctest target in node.gyp
includes node.gypi. Moving the appending from node.gypi to node target
in node.gyp fixes the issue.

Signed-off-by: Yihong Wang <yh.wang@ibm.com>

PR-URL: #16680
Backport-PR-URL: #17258
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

build: remove cctest extension
cctest has `so.59` extension when building node shared library in linux.
The appending is defined in node.gypi and the cctest target in node.gyp
includes node.gypi. Moving the appending from node.gypi to node target
in node.gyp fixes the issue.

Signed-off-by: Yihong Wang <yh.wang@ibm.com>

PR-URL: nodejs#16680
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

@refack refack removed their assignment Oct 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.