Join GitHub today
added template for better error explanation to assert.ok error message #16829
Hi @chrbergert! Thanks for the PR and welcome. A few things:
So, a few things:
assert.ok(ret.error, 'child process does not error when maxBuffer is set to 1');
I think I'd prefer this:
assert.ok(ret.error, 'error expected when maxBuffer is set to 1');
// This test checks that the maxBuffer option for child_process.spawnSync() // works as expected.
first of all, thanks for all the input and the warm welcome.
Before I ran lint-js locally and experimented a bit with it. Think I got the process for this, finally.
So, hope it goes through now and thanks again helping me doing my first contribution to this awesome project.
CI was good except for Raspberry Pi devices which have (had?) been having build problems. Let's try again: https://ci.nodejs.org/job/node-test-commit-arm-fanned/12541/