New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use crashOnUnhandledRejection #17226

Closed
wants to merge 1 commit into
base: master
from

Conversation

@roth1002
Contributor

roth1002 commented Nov 22, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
test: use crashOnUnhandledRejection
Add common.crashOnUnhandledRejection to
test/parallell/test-microtask-queue-run-domain.js

@roth1002 roth1002 changed the title from test: Add common.crashOnUnhandledRejection() in test-microtask-queue-run-domain.js to test: use crashOnUnhandledRejection Nov 22, 2017

@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

LGTM

jasnell added a commit that referenced this pull request Nov 22, 2017

test: use crashOnUnhandledRejection
Add common.crashOnUnhandledRejection to
test/parallell/test-microtask-queue-run-domain.js

PR-URL: #17226
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Nov 22, 2017

Member

Landed in 1cc8ec3! Thank you and congrats on your PR to core!

Member

jasnell commented Nov 22, 2017

Landed in 1cc8ec3! Thank you and congrats on your PR to core!

@jasnell jasnell closed this Nov 22, 2017

MylesBorins added a commit that referenced this pull request Dec 12, 2017

test: use crashOnUnhandledRejection
Add common.crashOnUnhandledRejection to
test/parallell/test-microtask-queue-run-domain.js

PR-URL: #17226
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

test: use crashOnUnhandledRejection
Add common.crashOnUnhandledRejection to
test/parallell/test-microtask-queue-run-domain.js

PR-URL: #17226
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 12, 2017

Merged

v9.3.0 proposal #17631

gibfahn added a commit that referenced this pull request Dec 19, 2017

test: use crashOnUnhandledRejection
Add common.crashOnUnhandledRejection to
test/parallell/test-microtask-queue-run-domain.js

PR-URL: #17226
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 19, 2017

test: use crashOnUnhandledRejection
Add common.crashOnUnhandledRejection to
test/parallell/test-microtask-queue-run-domain.js

PR-URL: #17226
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Closed

v8.9.4 proposal #17772

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: use crashOnUnhandledRejection
Add common.crashOnUnhandledRejection to
test/parallell/test-microtask-queue-run-domain.js

PR-URL: #17226
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Merged

v8.9.4 proposal #17774

@MylesBorins MylesBorins referenced this pull request Dec 20, 2017

Merged

v6.12.3 proposal #17776

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

test: use crashOnUnhandledRejection
Add common.crashOnUnhandledRejection to
test/parallell/test-microtask-queue-run-domain.js

PR-URL: nodejs#17226
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

test: use crashOnUnhandledRejection
Add common.crashOnUnhandledRejection to
test/parallell/test-microtask-queue-run-domain.js

PR-URL: nodejs#17226
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment