New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting test to use Countdown #17505

Closed
wants to merge 9 commits into
base: master
from

Conversation

Projects
None yet
7 participants
@TomerOmri
Contributor

TomerOmri commented Dec 6, 2017

Hi,
this is my first PR :)
I worked on test-http-should-keep-alive.js
Ref: #17169

#Goodness squad

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
@apapirovski

Thanks for the contribution @TomerOmri. Since this is using Countdown now, it should be possible to refactor such that the requests and responses counters are no longer necessary.

Since there's always only one makeRequest in progress, we could for example use something like this in makeRequest:

response = SERVER_RESPONSES.shift();
shouldKeepAlive = SHOULD_KEEP_ALIVE.shift();

where response and shouldKeepAlive are declared in the top scope (and can then be used within both the client handler and the server one).

Show outdated Hide outdated test/parallel/test-http-expect-handling.js Outdated
Show outdated Hide outdated test/parallel/test-http-keepalive-client.js Outdated
Show outdated Hide outdated test/parallel/test-http-should-keep-alive.js Outdated
Show outdated Hide outdated test/parallel/test-http-should-keep-alive.js Outdated
@TomerOmri

This comment has been minimized.

Show comment
Hide comment
@TomerOmri

TomerOmri Dec 6, 2017

Contributor

Hi @apapirovski after an update,
waiting for your review.
Thanks!

Contributor

TomerOmri commented Dec 6, 2017

Hi @apapirovski after an update,
waiting for your review.
Thanks!

@apapirovski

A few small things left.

Show outdated Hide outdated test/parallel/test-http-should-keep-alive.js Outdated
Show outdated Hide outdated test/parallel/test-http-should-keep-alive.js Outdated
@TomerOmri

This comment has been minimized.

Show comment
Hide comment
@TomerOmri

TomerOmri Dec 7, 2017

Contributor

Hi @apapirovski
Thanks for the help im still learning. themake test -j4` runs with no issues.

Let me know if you find anything else that need to be changed.
Thanks!

Contributor

TomerOmri commented Dec 7, 2017

Hi @apapirovski
Thanks for the help im still learning. themake test -j4` runs with no issues.

Let me know if you find anything else that need to be changed.
Thanks!

@maclover7

One quick comment

Show outdated Hide outdated test/parallel/test-http-should-keep-alive.js Outdated
@apapirovski

This comment has been minimized.

Show comment
Hide comment
@daxlab

daxlab approved these changes Dec 9, 2017

@maclover7

This comment has been minimized.

Show comment
Hide comment
@maclover7

maclover7 Dec 9, 2017

Member

Landing...

Member

maclover7 commented Dec 9, 2017

Landing...

@maclover7 maclover7 self-assigned this Dec 9, 2017

@maclover7

This comment has been minimized.

Show comment
Hide comment
@maclover7

maclover7 Dec 9, 2017

Member

Landed in e9d1e12, congrats on your first PR to Node.js!
❤️ 💚 💙 💛 💜

Member

maclover7 commented Dec 9, 2017

Landed in e9d1e12, congrats on your first PR to Node.js!
❤️ 💚 💙 💛 💜

@maclover7 maclover7 closed this Dec 9, 2017

maclover7 added a commit to maclover7/node that referenced this pull request Dec 9, 2017

test: update test-http-should-keep-alive to use countdown
PR-URL: nodejs#17505
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

test: update test-http-should-keep-alive to use countdown
PR-URL: #17505
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

test: update test-http-should-keep-alive to use countdown
PR-URL: #17505
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>

@MylesBorins MylesBorins referenced this pull request Dec 12, 2017

Merged

v9.3.0 proposal #17631

@addaleax addaleax removed the author ready label Dec 13, 2017

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: update test-http-should-keep-alive to use countdown
PR-URL: #17505
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: update test-http-should-keep-alive to use countdown
PR-URL: #17505
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Closed

v8.9.4 proposal #17772

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: update test-http-should-keep-alive to use countdown
PR-URL: #17505
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Merged

v8.9.4 proposal #17774

@MylesBorins MylesBorins referenced this pull request Dec 20, 2017

Merged

v6.12.3 proposal #17776

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

test: update test-http-should-keep-alive to use countdown
PR-URL: nodejs#17505
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

test: update test-http-should-keep-alive to use countdown
PR-URL: nodejs#17505
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment