Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: convert utcDate to use setTimeout #17800

Closed
wants to merge 1 commit into from
Closed

http: convert utcDate to use setTimeout #17800

wants to merge 1 commit into from

Conversation

Fishrock123
Copy link
Contributor

@Fishrock123 Fishrock123 commented Dec 21, 2017 •
edited
Loading

A sort-of follow-up to #17704, this
removes the last internal use of enroll().

Edit - CI: https://ci.nodejs.org/job/node-test-pull-request/12243/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

http

@Fishrock123 Fishrock123 added http Issues or PRs related to the http subsystem. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. labels Dec 21, 2017
@nodejs-github-bot nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Dec 21, 2017
@Fishrock123
http: convert utcDate to use setTimeout
1672f00 
A sort-of follow-up to nodejs#17704, this
removes the last internal use of enroll().
@Fishrock123
Copy link
Contributor Author

Fishrock123 commented Dec 21, 2017 •
edited
Loading

Looks like alpine exploded in addon compilation? weird but not really related: https://ci.nodejs.org/job/node-test-commit-linux/15128/nodes=alpine34-container-x64/console
¯\_(ツ)_/¯

@maclover7 maclover7 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 24, 2017
addaleax
addaleax reviewed Dec 27, 2017
View reviewed changes
lib/internal/http.js
}
return dateCache;
}
utcDate._onTimeout = function() {

function timeout() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe call this function resetCache or sth like that, timeout doesn't really say what it's doing...

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Dec 28, 2017
@Fishrock123 @BridgeAR
http: convert utcDate to use setTimeout
f94eec0 
A sort-of follow-up to nodejs#17704, this
removes the last internal use of enroll().

PR-URL: nodejs#17800
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BridgeAR
Copy link
Member

Landed in f94eec0

(I changed the function name to resetCache as suggested by @addaleax)

@BridgeAR BridgeAR closed this Dec 28, 2017
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 29, 2017
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@Fishrock123 @MylesBorins
http: convert utcDate to use setTimeout
e5394e5 
A sort-of follow-up to #17704, this
removes the last internal use of enroll().

PR-URL: #17800
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@Fishrock123 @MylesBorins
http: convert utcDate to use setTimeout
160df64 
A sort-of follow-up to #17704, this
removes the last internal use of enroll().

PR-URL: #17800
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos mentioned this pull request Jan 9, 2018
Closed
4 tasks
@MylesBorins
Copy link
Contributor

Setting don't land as this relies on a semver-major commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@evanlucas evanlucas evanlucas approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@JungMinu JungMinu JungMinu approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.