Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: refactor tests to not rely on timing #17828

Closed
wants to merge 1 commit into from
Closed

repl: refactor tests to not rely on timing #17828

wants to merge 1 commit into from

Conversation

bmeck
Copy link
Member

@bmeck bmeck commented Dec 22, 2017

Tests relying on synchronous timing have been migrated to use events.

This is in preparation for more robust testing with the top level await transform. Some minor naming changes were also made to try and make bits more consistent as I was reading them.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

repl, test

@nodejs-github-bot nodejs-github-bot added the repl Issues and PRs related to the REPL subsystem. label Dec 22, 2017
@Trott
Copy link
Member

Trott commented Dec 28, 2017

@nodejs/testing @addaleax @Fishrock123 @princejwesley

@joyeecheung
Copy link
Member

@bmeck this needs a rebase, thanks!

@bmeck
repl: refactor tests to not rely on timing
01e697e 
Tests relying on synchronous timing have been migrated to use events.
@targos
Copy link
Member

targos commented Jan 20, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/12645/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 7, 2018
@apapirovski
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/13038/

@BridgeAR
Copy link
Member

Landed in de848ac 🎉

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Feb 10, 2018
@bmeck @BridgeAR
repl: refactor tests to not rely on timing
de848ac 
Tests relying on synchronous timing have been migrated to use events.

PR-URL: nodejs#17828
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@BridgeAR BridgeAR closed this Feb 10, 2018
@BridgeAR
Copy link
Member

Hm, this broke multilines in the repl.

This can easily be verified with:

{

After entering that, it is not possible to type anything anymore.

@bmeck do you think you can get this working soon again? Otherwise I guess the best will be to revert it?

@BridgeAR BridgeAR mentioned this pull request Feb 11, 2018
Closed
4 tasks
@bmeck
Copy link
Member Author

bmeck commented Feb 11, 2018

@BridgeAR I'll take a look tomorrow and think I can fix it.

@cjihrig cjihrig mentioned this pull request Feb 11, 2018
Merged
2 tasks
BridgeAR added a commit to BridgeAR/node that referenced this pull request Feb 12, 2018
@BridgeAR
Revert "repl: refactor tests to not rely on timing"
1fc373b 
This reverts commit de848ac.

The commit broke multiline repl.

PR-URL: nodejs#18715
Refs: nodejs#17828
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
cjihrig added a commit to cjihrig/node that referenced this pull request Feb 14, 2018
@cjihrig
test: add multiline repl input regression test
92c86fd 
This commit adds a regression test for
de848ac, which broke
multiline input in the REPL.

PR-URL: nodejs#18718
Refs: nodejs#17828
Refs: nodejs#18715
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins
Copy link
Member

MylesBorins commented Feb 21, 2018 •
edited
Loading

Should this be backported to v9.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

edit: looks like it was reverted setting don't land

MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@cjihrig @MylesBorins
test: add multiline repl input regression test
e1eccc3 
This commit adds a regression test for
de848ac, which broke
multiline input in the REPL.

PR-URL: #18718
Refs: #17828
Refs: #18715
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@cjihrig @MylesBorins
test: add multiline repl input regression test
d6786d2 
This commit adds a regression test for
de848ac, which broke
multiline input in the REPL.

PR-URL: #18718
Refs: #17828
Refs: #18715
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@bmeck @MayaLekova
repl: refactor tests to not rely on timing
1a541a1 
Tests relying on synchronous timing have been migrated to use events.

PR-URL: nodejs#17828
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@BridgeAR @MayaLekova
Revert "repl: refactor tests to not rely on timing"
240bca8 
This reverts commit de848ac.

The commit broke multiline repl.

PR-URL: nodejs#18715
Refs: nodejs#17828
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@cjihrig @MayaLekova
test: add multiline repl input regression test
adf3d20 
This commit adds a regression test for
de848ac, which broke
multiline input in the REPL.

PR-URL: nodejs#18718
Refs: nodejs#17828
Refs: nodejs#18715
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos targos removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 8, 2018
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
@cjihrig @MylesBorins
test: add multiline repl input regression test
bc66d4e 
This commit adds a regression test for
de848ac, which broke
multiline input in the REPL.

PR-URL: #18718
Refs: #17828
Refs: #18715
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
@cjihrig @MylesBorins
test: add multiline repl input regression test
08ce81f 
This commit adds a regression test for
de848ac, which broke
multiline input in the REPL.

PR-URL: #18718
Refs: #17828
Refs: #18715
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Aug 9, 2018
@cjihrig @MylesBorins
test: add multiline repl input regression test
c0c1fc5 
This commit adds a regression test for
de848ac, which broke
multiline input in the REPL.

PR-URL: #18718
Refs: #17828
Refs: #18715
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2018
@cjihrig @MylesBorins
test: add multiline repl input regression test
1169590 
This commit adds a regression test for
de848ac, which broke
multiline input in the REPL.

PR-URL: #18718
Refs: #17828
Refs: #18715
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos targos added this to Don't land (for now) in v10.x Sep 23, 2018
@targos targos moved this from Don't land (for now) to Don't land (ever) in v10.x Sep 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
repl Issues and PRs related to the REPL subsystem.
Projects
No open projects
v10.x
  
Don't land (ever)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@bmeck @Trott @joyeecheung @targos @apapirovski @BridgeAR @MylesBorins @jasnell @nodejs-github-bot