Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: put .PHONY on line before of its target definition. #17964

Closed
wants to merge 1 commit into from
Closed

build: put .PHONY on line before of its target definition. #17964

wants to merge 1 commit into from

Conversation

oantoro
Copy link
Contributor

@oantoro oantoro commented Jan 3, 2018

Before this change, the .PHONY is followed by multiple targets. Now it is multiple .PHONY for each target

Refs: #16968

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

@oantoro
build: put .PHONY on line before of its target definition.
752cbec 
Before this change, the .PHONY is followed by multiple targets. Now it is multiple .PHONY for each target

Refs: nodejs#16968
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Jan 3, 2018
@oantoro
Copy link
Contributor Author

oantoro commented Jan 4, 2018

@bnoordhuis could you review this PR? Thank you

@joyeecheung
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/12402/

@BridgeAR BridgeAR added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jan 4, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 5, 2018
@oantoro @BridgeAR
build: put .PHONY directly before its target
feaf6ac 
Before this change, the .PHONY is followed by multiple targets.
Now it is multiple .PHONY for each target.

PR-URL: nodejs#17964
Refs: nodejs#16968
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR
Copy link
Member

BridgeAR commented Jan 5, 2018

Landed in feaf6ac

I fixed the commit message while landing.

@BridgeAR BridgeAR closed this Jan 5, 2018
@oantoro oantoro deleted the phony-style branch January 5, 2018 15:18
@targos targos mentioned this pull request Jan 7, 2018
Closed
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@oantoro @MylesBorins
build: put .PHONY directly before its target
64e6e46 
Before this change, the .PHONY is followed by multiple targets.
Now it is multiple .PHONY for each target.

PR-URL: #17964
Refs: #16968
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@oantoro @MylesBorins
build: put .PHONY directly before its target
84883f2 
Before this change, the .PHONY is followed by multiple targets.
Now it is multiple .PHONY for each target.

PR-URL: #17964
Refs: #16968
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@oantoro @MylesBorins
build: put .PHONY directly before its target
224033d 
Before this change, the .PHONY is followed by multiple targets.
Now it is multiple .PHONY for each target.

PR-URL: #17964
Refs: #16968
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
Merged
@TimothyGu TimothyGu removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 13, 2018
@MylesBorins
Copy link
Member

Should this be backported to LTS? if so it will need a backport

@MylesBorins

This comment has been minimized.

Sign in to view
@MylesBorins
Copy link
Member

ping @nodejs/build re: backport

@joyeecheung joyeecheung mentioned this pull request Aug 17, 2018
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@oantoro @joyeecheung @BridgeAR @MylesBorins @TimothyGu @nodejs-github-bot