Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: non-Ascii linter for /lib only #18043

Closed
wants to merge 4 commits into from
Closed

tools: non-Ascii linter for /lib only #18043

wants to merge 4 commits into from

Commits on Jan 19, 2018

  1. tools: non-Ascii linter for /lib only 

    Non-ASCII characters in /lib get compiled into the node binary,
and may bloat the binary size unnecessarily. A linter rule may
help prevent this.

Fixes: nodejs#11209
    @SirR4T
    SirR4T committed Jan 19, 2018
    Configuration menu
    Copy the full SHA
    3d63b03 View commit details
    Browse the repository at this point in the history

  2. tools: fix non-ascii linter detection 

    the linter should detect not just literals, but also source code
and all comments too.
    @SirR4T
    SirR4T committed Jan 19, 2018
    Configuration menu
    Copy the full SHA
    1399bf5 View commit details
    Browse the repository at this point in the history

  3. tools: using source.text instead of tokens

    @SirR4T
    SirR4T committed Jan 19, 2018
    Configuration menu
    Copy the full SHA
    bd452d5 View commit details
    Browse the repository at this point in the history

  4. Adding loc to report

    @SirR4T
    SirR4T committed Jan 19, 2018
    Configuration menu
    Copy the full SHA
    1e0ab23 View commit details
    Browse the repository at this point in the history