-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: add FileHandle to doc/type-parser.js #18601
tools: add FileHandle to doc/type-parser.js #18601
Conversation
Do I understand correctly that CI failure is unrelated? Should we wait till "all green"? |
@vsemozhetbyt It is but I would suggest restarting it. Unless that box is down? |
@apapirovski I will do, but I already restarted CI here and in another PR, it always fails recently, Maybe something wrong with machines. New CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/156/ |
@vsemozhetbyt I pinged @nodejs/build on IRC. Hopefully they can have a look. |
New green CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/157/ (possible fix: #18605) |
Landed in bff5d5b |
With a quick look it appears this only applies to the promise fs apis, if mistaken please change labels and open a backport |
PR-URL: nodejs#18601 Refs: nodejs#18407 Refs: nodejs#18444 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
doc, fs, tools
Refs: #18407
Refs: #18444