fs: throw more synchronous errors in JS land #19041

joyeecheung · 2018-02-27T18:47:00Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Affected core subsystem(s)

fs

After this PR, all synchronous errors in node_file.cc are migrated into JS land, and they all have error tests in test-fs-error-messages.js (the asynchronous errors are tested as well).

The only synchronous errors left in fs is being fixed in #17851

joyeecheung · 2018-02-27T18:49:09Z

CI: https://ci.nodejs.org/job/node-test-pull-request/13397/

targos · 2018-02-27T19:12:35Z

src/node_file.cc

-  size_t len;
-  int64_t pos;
+  const int argc = args.Length();
+  CHECK_GE(argc, 4);


joyeecheung · 2018-03-02T13:23:14Z

Landed in 7cadb57...f7e5b38 with @targos 's comment addressed. Thanks!

PR-URL: #19041 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

joaocgreis · 2018-03-03T02:24:07Z

This PR landed with a full red Windows CI and has broken master. Should we revert or is it something simple to fix?

joyeecheung · 2018-03-03T04:11:50Z

@joaocgreis The windows CI seems to be broken by this

  c:\workspace\node-test-binary-windows>TASKKILL /F /IM node.exe /T   || TRUE
  ERROR: The process "node.exe" not found.

Not sure how it is related to this PR...

richardlau · 2018-03-03T05:06:38Z

@joyeecheung e.g., https://ci.nodejs.org/job/node-test-binary-windows/15333/COMPILED_BY=vs2017,RUNNER=win10,RUN_SUBSET=0/console

Building addons
C:\Windows\SYSTEM32\cmd.exe[3240]: src\node_file.cc:1286: Assertion `(argc) == (7)' failed.
 1: node::DecodeWrite
 2: node::DecodeWrite
 3: v8::internal::ParseInfo::character_stream
 4: v8::internal::wasm::NativeModuleDeserializer::DeserializeFullBuffer
 5: v8::internal::LocalEmbedderHeapTracer::RequiresImmediateWrapperProcessing
 6: v8::internal::LocalEmbedderHeapTracer::RequiresImmediateWrapperProcessing
 7: v8::internal::LocalEmbedderHeapTracer::RequiresImmediateWrapperProcessing
 8: 000003FE44E04201

joyeecheung · 2018-03-03T07:41:26Z

@richardlau Ah, so the ERROR: thing can be ignored since they are no real errors...didn't look down below that, sorry.

I think I have found the culprit..fix coming up.

The binding writeBuffer has been changed in nodejs#19041 and it now requires the last argument to be a context object. makeSyncWrite was not updated accordingly, resulting assertions on Windows. This patch fixes the usage of writeBuffer there.

joyeecheung · 2018-03-03T08:02:42Z

Fix in #19103

The binding writeBuffer has been changed in #19041 and it now requires the last argument to be a context object. makeSyncWrite was not updated accordingly, resulting assertions on Windows. This patch fixes the usage of writeBuffer there. Also fix errors.uvException() so error.message are no longer enumerable, this fixes the deepStrictEqual assertion on the error object in test-stdout-close-catch. PR-URL: #19103 Refs: #19041 Reviewed-By: Anna Henningsen <anna@addaleax.net>

SYNC_REQ has been removed. See nodejs/node#18297 nodejs/node#19041

PR-URL: nodejs#19041 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

The binding writeBuffer has been changed in nodejs#19041 and it now requires the last argument to be a context object. makeSyncWrite was not updated accordingly, resulting assertions on Windows. This patch fixes the usage of writeBuffer there. Also fix errors.uvException() so error.message are no longer enumerable, this fixes the deepStrictEqual assertion on the error object in test-stdout-close-catch. PR-URL: nodejs#19103 Refs: nodejs#19041 Reviewed-By: Anna Henningsen <anna@addaleax.net>

joyeecheung added 7 commits February 28, 2018 02:42

fs: throw readSync errors in JS

e4474af

fs: throw fchmodSync errors in JS

5660ccf

fs: throw fchownSync errors in JS

fbdd350

fs: throw writeSync errors in JS

fbc8679

fs: throw futimesSync errors in JS

4d80e22

fs: use SyncCall in WriteBuffers

787851c

fs: remove unused SYNC_* helpers

1e71351

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. labels Feb 27, 2018

joyeecheung added the semver-major PRs that contain breaking changes and should be released in the next major version. label Feb 27, 2018

targos approved these changes Feb 27, 2018

View reviewed changes

src/node_file.cc

size_t len;

int64_t pos;

const int argc = args.Length();

CHECK_GE(argc, 4);

Copy link

Member

targos Feb 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5

jasnell approved these changes Feb 28, 2018

View reviewed changes

BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 1, 2018

XadillaX approved these changes Mar 2, 2018

View reviewed changes

joyeecheung closed this Mar 2, 2018

joyeecheung added a commit that referenced this pull request Mar 2, 2018

fs: throw readSync errors in JS

c6acfdb

PR-URL: #19041 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

joyeecheung added a commit that referenced this pull request Mar 2, 2018

fs: throw fchmodSync errors in JS

79b1954

PR-URL: #19041 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

joyeecheung added a commit that referenced this pull request Mar 2, 2018

fs: throw fchownSync errors in JS

1650eae

PR-URL: #19041 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

joyeecheung added a commit that referenced this pull request Mar 2, 2018

fs: throw writeSync errors in JS

994320b

PR-URL: #19041 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

joyeecheung added a commit that referenced this pull request Mar 2, 2018

fs: throw futimesSync errors in JS

49dd809

PR-URL: #19041 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

joyeecheung added a commit that referenced this pull request Mar 2, 2018

fs: use SyncCall in WriteBuffers

80bd2da

PR-URL: #19041 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

joyeecheung added a commit that referenced this pull request Mar 2, 2018

fs: remove unused SYNC_* helpers

f7e5b38

PR-URL: #19041 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

joyeecheung mentioned this pull request Mar 3, 2018

net: fix usage of writeBuffer in makeSyncWrite #19103

Closed

3 tasks

joyeecheung mentioned this pull request Mar 3, 2018

ncu-ci: command that shows results of jenkins nodejs/node-core-utils#161

Merged

alexeykuzmin added a commit to electron/node that referenced this pull request Apr 10, 2018

fixup! Add fs.statSyncNoException

e4daabc

SYNC_REQ has been removed. See nodejs/node#18297 nodejs/node#19041

alexeykuzmin added a commit to electron/node that referenced this pull request Apr 27, 2018

fixup! Add fs.statSyncNoException

bc89511

SYNC_REQ has been removed. See nodejs/node#18297 nodejs/node#19041

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018

fs: throw readSync errors in JS

ff0526f

PR-URL: nodejs#19041 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018

fs: throw fchmodSync errors in JS

2a6303f

PR-URL: nodejs#19041 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018

fs: throw fchownSync errors in JS

ededf9b

PR-URL: nodejs#19041 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018

fs: throw writeSync errors in JS

a8bf50e

PR-URL: nodejs#19041 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018

fs: throw futimesSync errors in JS

fb20db7

PR-URL: nodejs#19041 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018

fs: use SyncCall in WriteBuffers

9e8e1de

PR-URL: nodejs#19041 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018

fs: remove unused SYNC_* helpers

da08006

PR-URL: nodejs#19041 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fs: throw more synchronous errors in JS land #19041

fs: throw more synchronous errors in JS land #19041

joyeecheung commented Feb 27, 2018

joyeecheung commented Feb 27, 2018

targos Feb 27, 2018

joyeecheung commented Mar 2, 2018

joaocgreis commented Mar 3, 2018

joyeecheung commented Mar 3, 2018 •

edited

Loading

richardlau commented Mar 3, 2018

joyeecheung commented Mar 3, 2018

joyeecheung commented Mar 3, 2018

fs: throw more synchronous errors in JS land #19041

fs: throw more synchronous errors in JS land #19041

Conversation

joyeecheung commented Feb 27, 2018

Checklist

Affected core subsystem(s)

joyeecheung commented Feb 27, 2018

targos Feb 27, 2018

Choose a reason for hiding this comment

joyeecheung commented Mar 2, 2018

joaocgreis commented Mar 3, 2018

joyeecheung commented Mar 3, 2018 • edited Loading

richardlau commented Mar 3, 2018

joyeecheung commented Mar 3, 2018

joyeecheung commented Mar 3, 2018

joyeecheung commented Mar 3, 2018 •

edited

Loading