-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto: deprecate Decipher.finaltol #19353
Conversation
doc/api/deprecations.md
Outdated
@@ -950,11 +950,21 @@ deprecated if the assigned value is not a string, boolean, or number. In the | |||
future, such assignment may result in a thrown error. Please convert the | |||
property to a string before assigning it to `process.env`. | |||
|
|||
<a id="DEP00XX"></a> | |||
### DEP00XX: crypto.Decipher.finaltol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should Decipher
here and below be lowercased since it's referring to a prototype method and not a static method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that decipher.finaltol
is better than Decipher.finaltol
here, but crypto.decipher.finaltol
looks weird (since there is no decipher
property on crypto
). I changed all occurrences to lowercase and removed the crypto.
prefix. Is there a better way to do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what dropping crypto.
and using lowercase is fine, especially since .final()
is linked to and should give enough context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems unused to me.
PR-URL: #19353 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Landed in 19f3927, deprecation code is DEP0105. |
Refs: #19353 PR-URL: #19941 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Ever since eaf1343,
Decipher.finaltol()
has been an undocumented alias forDecipher.final()
. Sadly, @bnoordhuis comment ("remove someday") was lost at some point in the last six years, but I believe the time has finally come.The function has never been documented, it has no advantage over
.final()
, there is exactly one test which uses it, and there seems to be absolutely no usage on GitHub.cc @danbev
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes