test: amplify and optimize doctool/test-make-doc #19581
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
|
One ARM fail seems doc unrelated. |
BridgeAR
approved these changes
Mar 25, 2018
test/doctool/test-make-doc.js
Outdated
| assert.ok( | ||
| fs.statSync(path.join(apiPath, actualDoc)).size !== 0, | ||
| `${actualDoc} is empty` | ||
| ); |
There was a problem hiding this comment.
This could actually be combined with the upper loop. That way the loop has to run only once instead of twice.
|
The same ARM fail seems doc unrelated again. |
|
ARM-fanned re-run: https://ci.nodejs.org/job/node-test-commit-arm-fanned/15425/ |
joyeecheung
approved these changes
Mar 26, 2018
|
ARM-fanned all green. |
vsemozhetbyt
added
the
author ready
vsemozhetbyt
added a commit
that referenced
this pull request
Mar 28, 2018
PR-URL: #19581 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
|
Landed in b5884fb |
targos
pushed a commit
that referenced
this pull request
Apr 2, 2018
PR-URL: #19581 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesCurrently, the
doctool/test-make-doc.jshas 2 tiny performance nits and 2 logic oversights.Performance nits
Logic oversights.
Makefilegenerates docs by getting theconsole.log()output from thetools/doc/generate.jsand redirecting it to the doc files. Iftools/doc/generate.jsthrows, an empty doc file is still created. So we can have a situation when the last.mdsource has an error and all the needed files are nevertheless present, just one of them is empty. So we need to check if all the files are not empty.Refactoring strategy
The test is changed considerably, but it may be more strict, full and performant in this form.