url: make urlToOptions() handle IPv6 literals #19720
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strip the enclosing square brackets from the parsed hostname.
nodejs-github-bot
added
dont-land-on-v4.x
whatwg-url
jasnell
approved these changes
Apr 1, 2018
BridgeAR
approved these changes
Apr 9, 2018
| @@ -1312,7 +1312,9 @@ function domainToUnicode(domain) { | |||
| function urlToOptions(url) { | |||
| var options = { | |||
| protocol: url.protocol, | |||
| hostname: url.hostname, | |||
| hostname: url.hostname.startsWith('[') ? | |||
There was a problem hiding this comment.
Nit: from a performance standpoint it would be better to use charCodeAt.
There was a problem hiding this comment.
There was a problem hiding this comment.
I don’t think this is a performance-relevant function anyway. The actual HTTP roundtrip will take much longer.
|
Landed in fa2d43b. |
lpinca
added a commit
that referenced
this pull request
Apr 10, 2018
Strip the enclosing square brackets from the parsed hostname. PR-URL: #19720 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2018
Strip the enclosing square brackets from the parsed hostname. PR-URL: #19720 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strip the enclosing square brackets from the parsed hostname.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes