module: move options checks from C++ to JS #19822
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targos
added
the
semver-major
nodejs-github-bot
added
c++
targos
added
errors
mcollina
approved these changes
Apr 5, 2018
guybedford
approved these changes
Apr 5, 2018
| if ((prop >> 0) !== prop) { | ||
| throw new ERR_OUT_OF_RANGE(propName, '32-bit integer', prop); | ||
| } | ||
| } |
There was a problem hiding this comment.
Does this not belong somewhere a little more generic perhaps? Somewhat surprising there isn't already something for this too?
There was a problem hiding this comment.
I agree, especially since I copied this function from another file. I'll look into bringing together type validation functions in another PR if that's fine for you.
| let timeout = options.timeout; | ||
| if (timeout === undefined) { | ||
| timeout = -1; | ||
| } else if (!Number.isInteger(timeout) || timeout <= 0) { |
There was a problem hiding this comment.
Should timeout also run through validateInteger?
There was a problem hiding this comment.
The check is a bit different. timeout may not be negative, while validateInteger allows negative values.
devsnek
approved these changes
Apr 5, 2018
jasnell
approved these changes
Apr 5, 2018
|
Landed in 77b52fd |
targos
added a commit
that referenced
this pull request
Apr 7, 2018
PR-URL: #19822 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #19398
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes/cc @joyeecheung @TimothyGu @devsnek @nodejs/tsc