Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert: fix error message #19865

Closed
wants to merge 1 commit into from
Closed

assert: fix error message #19865

wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Apr 7, 2018

assert.throws also accepts objects and errors as input. This fixes
the error message accodingly.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@BridgeAR
assert: fix error message
bdf27b1 
`assert.throws` also accepts objects and errors as input. This fixes
the error message accodingly.
@nodejs-github-bot nodejs-github-bot added the assert Issues and PRs related to the assert subsystem. label Apr 7, 2018
@BridgeAR
Copy link
Member Author

BridgeAR commented Apr 7, 2018

CI https://ci.nodejs.org/job/node-test-pull-request/14119/

@BridgeAR BridgeAR mentioned this pull request Apr 7, 2018
Closed
4 tasks
@BridgeAR BridgeAR added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 7, 2018
@BridgeAR
Copy link
Member Author

BridgeAR commented Apr 9, 2018

Landed in 252eb2d

@BridgeAR BridgeAR closed this Apr 9, 2018
BridgeAR added a commit to BridgeAR/node that referenced this pull request Apr 9, 2018
@BridgeAR
assert: fix error message
252eb2d 
`assert.throws` also accepts objects and errors as input. This fixes
the error message accodingly.

PR-URL: nodejs#19865
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR added a commit to BridgeAR/node that referenced this pull request May 1, 2018
@BridgeAR
assert: fix error message
0c354a4 
`assert.throws` also accepts objects and errors as input. This fixes
the error message accodingly.

PR-URL: nodejs#19865
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR deleted the fix-throws-error-message branch January 20, 2020 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BridgeAR @lpinca @cjihrig @nodejs-github-bot