-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: check without_ssl in warn openssl_no_asm #19934
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s/witout_ssl/without_ssl/ in commit message |
Currently when configuring --without-ssl the following warning is displayed: WARNING: openssl_no_asm is enabled due to missed or old assembler. Please refer BUILDING.md This commit adds a check of options.without_ssl to avoid this warning when --without-ssl is used.
node-test-binary-windows failure looks unrelatednot ok 538 sequential/test-inspector-async-hook-setup-at-inspect-brk
---
duration_ms: 0.498
severity: fail
stack: |-
[test] Connecting to a child Node process
[test] Testing /json/list
[err] Debugger listening on ws://127.0.0.1:54669/e41bbf4a-fd83-4c28-9d77-a811ecc70db6
[err] For help, see: https://nodejs.org/en/docs/inspector
[err]
[test] Verify node waits for the frontend to disconnect
[err] Debugger attached.
[err] Waiting for the debugger to disconnect...
[err]
[test] Verify basic properties of asyncStackTrace
{ AssertionError [ERR_ASSERTION]: 55 strictEqual 3221225477
at runTests (c:\workspace\node-test-binary-windows\test\sequential\test-inspector-async-hook-setup-at-inspect-brk.js:48:10)
at process._tickCallback (internal/process/next_tick.js:178:7)
generatedMessage: true,
name: 'AssertionError [ERR_ASSERTION]',
code: 'ERR_ASSERTION',
actual: 55,
expected: 3221225477,
operator: 'strictEqual' }
1
... |
144ef8a
to
67bb43c
Compare
BridgeAR
approved these changes
Apr 11, 2018
Landed in 89cd749. |
danbev
added a commit
that referenced
this pull request
Apr 14, 2018
Currently when configuring --without-ssl the following warning is displayed: WARNING: openssl_no_asm is enabled due to missed or old assembler. Please refer BUILDING.md This commit adds a check of options.without_ssl to avoid this warning when --without-ssl is used. PR-URL: #19934 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
jasnell
pushed a commit
that referenced
this pull request
Apr 16, 2018
Currently when configuring --without-ssl the following warning is displayed: WARNING: openssl_no_asm is enabled due to missed or old assembler. Please refer BUILDING.md This commit adds a check of options.without_ssl to avoid this warning when --without-ssl is used. PR-URL: #19934 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This seems to be based on a semver-major commit. I added the do not land labels accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
build
Issues and PRs related to build files or the CI.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when configuring
--without-ssl
the following warning isdisplayed:
This commit adds a check of options.without_ssl to avoid this warning
when --without-ssl is used.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes