errors: alter ERR_INVALID_PROTOCOL #19983
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
errors
jasnell
approved these changes
Apr 12, 2018
targos
approved these changes
Apr 12, 2018
BridgeAR
approved these changes
Apr 13, 2018
| @@ -38,7 +38,7 @@ invalidUrls.forEach((invalid) => { | |||
| () => { http.request(url.parse(invalid)); }, | |||
| { | |||
| code: 'ERR_INVALID_PROTOCOL', | |||
| type: Error | |||
| type: TypeError | |||
There was a problem hiding this comment.
Would you be so kind and also validate the message here? :-)
lpinca
approved these changes
Apr 14, 2018
trivikr
approved these changes
Apr 14, 2018
|
CI failure is unrelated. |
|
@davidmarkclements ... this needs a quick rebase when you get a moment. |
TimothyGu
approved these changes
Apr 15, 2018
BridgeAR
added
the
semver-major
changes the base instance for ERR_INVALID_PROTOCOL from Error to TypeError as a more accurate representation of the error.
|
Landed in 5c42578. |
lpinca
pushed a commit
that referenced
this pull request
Apr 16, 2018
Changes the base instance for ERR_INVALID_PROTOCOL from Error to TypeError as a more accurate representation of the error. PR-URL: #19983 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Apr 16, 2018
Changes the base instance for ERR_INVALID_PROTOCOL from Error to TypeError as a more accurate representation of the error. PR-URL: #19983 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes the base instance for ERR_INVALID_PROTOCOL
from Error to TypeError as a more accurate representation
of the error.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes