Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add tools/doc/README link in doc/STYLE_GUIDE #20071

Closed
wants to merge 1 commit into from
Closed

doc: add tools/doc/README link in doc/STYLE_GUIDE #20071

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Refs: #20047 (review)

This can be a temporal workaround till a possible major refactoring or merging so that this doc would not go off the radars.

@vsemozhetbyt vsemozhetbyt added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. fast-track PRs that do not need to wait for 48 hours to land. labels Apr 16, 2018
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 16, 2018
@vsemozhetbyt
Copy link
Contributor Author

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/533/

@vsemozhetbyt vsemozhetbyt mentioned this pull request Apr 16, 2018
Closed
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 16, 2018
vsemozhetbyt added a commit that referenced this pull request Apr 16, 2018
@vsemozhetbyt
doc: add tools/doc/README link in doc/STYLE_GUIDE
addc04b 
PR-URL: #20071
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@vsemozhetbyt
Copy link
Contributor Author

Landed in addc04b

@vsemozhetbyt vsemozhetbyt deleted the doc-link-doc-tools-readme branch April 16, 2018 16:18
jasnell pushed a commit that referenced this pull request Apr 16, 2018
@vsemozhetbyt @jasnell
doc: add tools/doc/README link in doc/STYLE_GUIDE
eca96f5 
PR-URL: #20071
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Aug 17, 2018
@vsemozhetbyt @MylesBorins
doc: add tools/doc/README link in doc/STYLE_GUIDE
14a5dd4 
PR-URL: #20071
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Aug 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vsemozhetbyt @lpinca @BridgeAR @MylesBorins @nodejs-github-bot