-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc,http2: add parameters for Http2Session:error event #20206
Conversation
Add parameters for the callback for the Http2Session:error event inline with the pattern in the rest of the documentation. Refs: nodejs/help#877 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please, add 👍 here to approve fast-tracking. |
Nit: please, try to not exceed 50 characters limit for commit title except extreme necessity. Say, since the module is clear from the rest of info, we can shorten the title on landing: doc: add parameters for Http2Session:error event |
@vsemozhetbyt sorry 😅 will keep that in mind while landing this one and for future PRs. Do you think this seems landable? |
@ryzokuken I think this can be landed as soon as on more collaborator adds 👍 to the comment so we have 2 non-author +1) |
Approved and landing. |
Add parameters for the callback for the Http2Session:error event inline with the pattern in the rest of the documentation. Refs: nodejs/help#877 (comment) PR-URL: #20206 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Landed in 63cae79 |
Add parameters for the callback for the Http2Session:error event inline with the pattern in the rest of the documentation. Refs: nodejs/help#877 (comment) PR-URL: #20206 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Add parameters for the callback for the Http2Session:error event inline with the pattern in the rest of the documentation. Refs: nodejs/help#877 (comment) PR-URL: nodejs#20206 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Add parameters for the callback for the Http2Session:error event inline with the pattern in the rest of the documentation. Refs: nodejs/help#877 (comment) PR-URL: nodejs#20206 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Add parameters for the callback for the Http2Session:error event inline with the pattern in the rest of the documentation. Refs: nodejs/help#877 (comment) PR-URL: nodejs#20206 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Add parameters for the callback for the Http2Session:error event inline with the pattern in the rest of the documentation. Refs: nodejs/help#877 (comment) PR-URL: nodejs#20206 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Add parameters for the callback for the Http2Session:error event inline with the pattern in the rest of the documentation. Refs: nodejs/help#877 (comment) Backport-PR-URL: #22850 PR-URL: #20206 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Add parameters for the callback for the Http2Session:error event
inline with the pattern in the rest of the documentation.
Refs: nodejs/help#877 (comment)
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes/cc @mcollina @nodejs/http2 @vsemozhetbyt