test: fix flaky child-process-exec-kill-throws #20213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kill the child process with `SIGKILL` to make sure the child process does not remain alive. Fixes: nodejs#20139
Trott
approved these changes
Apr 23, 2018
Trott
added
the
author ready
lpinca
approved these changes
Apr 23, 2018
trivikr
approved these changes
Apr 23, 2018
starkwang
approved these changes
Apr 23, 2018
jasnell
approved these changes
Apr 23, 2018
|
Landed in f1d9527 |
trivikr
pushed a commit
that referenced
this pull request
Apr 26, 2018
Kill the child process with `SIGKILL` to make sure the child process does not remain alive. Fixes: #20139 PR-URL: #20213 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 4, 2018
Kill the child process with `SIGKILL` to make sure the child process does not remain alive. Fixes: #20139 PR-URL: #20213 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kill the child process with
SIGKILLto make sure the child processdoes not remain alive.
Fixes: #20139
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes