-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test-child-process-exec-kill-throws fails intermittently on multiple platforms #20139
Comments
(The test file hasn't changed in almost a year.) |
@Trott I have been facing issues with:
perhaps one of the recent changes to the |
This test is also leaving child processes around causing the test runs to fail. Example: https://ci.nodejs.org/job/node-test-commit-osx/17954/nodes=osx1010/console |
@nodejs/build: As an immediate short term fix so macOS can get back to green, can someone do these:
|
I took care of test-requireio-osx1010-x64-1 but don't have a login on macstadium (will check docs to see if I can figure that one out). |
Failed again on https://ci.nodejs.org/job/node-test-commit/17903/ for #20177 |
Here's the relevant console messages from the one @ryzokuken reports above, before the link turns all 404 on us: not ok 133 parallel/test-child-process-exec-timeout
---
duration_ms: 0.264
severity: fail
exitcode: 1
stack: |-
assert.js:77
throw new AssertionError(obj);
^
AssertionError [ERR_ASSERTION]: Input A expected to strictly equal input B:
+ expected - actual
- 'SIGSEGV'
+ 'SIGTERM'
at cp.exec.common.mustCall (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/parallel/test-child-process-exec-timeout.js:34:12)
at /data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/common/index.js:474:15
at ChildProcess.exithandler (child_process.js:289:5)
at ChildProcess.emit (events.js:182:13)
at maybeClose (internal/child_process.js:944:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:233:5)
... |
Kill the child process with `SIGKILL` to make sure the child process does not remain alive. Fixes: nodejs#20139
Kill the child process with `SIGKILL` to make sure the child process does not remain alive. Fixes: #20139 PR-URL: #20213 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This is a bit disconcerting. Both are from the last hour or two. It seems to have popped up only in the last day or two, so it may be caused by something that landed recently?
Here it is timing out on AIX:
https://ci.nodejs.org/job/node-test-commit-aix/14317/nodes=aix61-ppc64/console
Here it is timing out on macOS:
https://ci.nodejs.org/job/node-test-commit-osx/17926/nodes=osx1010/console
@nodejs/child_process
The text was updated successfully, but these errors were encountered: