test-child-process-exec-kill-throws fails intermittently on multiple platforms

[Trott]

• Version: 10.0.0-pre (master)
• Platform: n/a
• Subsystem: child_process test

This is a bit disconcerting. Both are from the last hour or two. It seems to have popped up only in the last day or two, so it may be caused by something that landed recently?

Here it is timing out on AIX:

https://ci.nodejs.org/job/node-test-commit-aix/14317/nodes=aix61-ppc64/console

not ok 357 parallel/test-child-process-exec-kill-throws
  ---
  duration_ms: 120.232
  severity: fail
  exitcode: -15
  stack: |-
    timeout

Here it is timing out on macOS:

https://ci.nodejs.org/job/node-test-commit-osx/17926/nodes=osx1010/console

not ok 548 parallel/test-child-process-exec-kill-throws
  ---
  duration_ms: 120.110
  severity: fail
  exitcode: -15
  stack: |-
    timeout

@nodejs/child_process

[Trott]

(The test file hasn't changed in almost a year.)

[ryzokuken]

@Trott I have been facing issues with:

not ok 191 parallel/test-child-process-exec-timeout
  ---
  duration_ms: 0.330
  severity: fail
  exitcode: 1
  stack: |-
    assert.js:76
      throw new AssertionError(obj);
      ^
    
    AssertionError [ERR_ASSERTION]: Input A expected to strictly equal input B:
    + expected - actual
    
    - 'SIGSEGV'
    + 'SIGTERM'
        at cp.exec.common.mustCall (/home/iojs/build/workspace/node-test-commit-linux/nodes/fedora-last-latest-x64/test/parallel/test-child-process-exec-timeout.js:34:12)
        at /home/iojs/build/workspace/node-test-commit-linux/nodes/fedora-last-latest-x64/test/common/index.js:474:15
        at ChildProcess.exithandler (child_process.js:289:5)
        at ChildProcess.emit (events.js:182:13)
        at maybeClose (internal/child_process.js:944:16)
        at Process.ChildProcess._handle.onexit (internal/child_process.js:233:5)
  ...

perhaps one of the recent changes to the child_process module went wrong?

[Trott]

This test is also leaving child processes around causing the test runs to fail. Example: https://ci.nodejs.org/job/node-test-commit-osx/17954/nodes=osx1010/console

[ryzokuken]

@Trott #20045 is also failing because of this.

I propose working on mitigating immediately. Let me know if I could help in any way.

[Trott]

@nodejs/build: As an immediate short term fix so macOS can get back to green, can someone do these:

• on test-requireio-osx1010-x64-1: sudo kill -9 8467
• on test-macstadium-macos10.10-x64-2: sudo kill -9 62646

[Trott]

I took care of test-requireio-osx1010-x64-1 but don't have a login on macstadium (will check docs to see if I can figure that one out).

[ryzokuken]

Failed again on https://ci.nodejs.org/job/node-test-commit/17903/ for #20177

[Trott]

Here's the relevant console messages from the one @ryzokuken reports above, before the link turns all 404 on us:

not ok 133 parallel/test-child-process-exec-timeout
  ---
  duration_ms: 0.264
  severity: fail
  exitcode: 1
  stack: |-
    assert.js:77
      throw new AssertionError(obj);
      ^
    
    AssertionError [ERR_ASSERTION]: Input A expected to strictly equal input B:
    + expected - actual
    
    - 'SIGSEGV'
    + 'SIGTERM'
        at cp.exec.common.mustCall (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/parallel/test-child-process-exec-timeout.js:34:12)
        at /data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/common/index.js:474:15
        at ChildProcess.exithandler (child_process.js:289:5)
        at ChildProcess.emit (events.js:182:13)
        at maybeClose (internal/child_process.js:944:16)
        at Process.ChildProcess._handle.onexit (internal/child_process.js:233:5)
  ...