fs: use isUint32 in isFd #20330
Closed
fs: use isUint32 in isFd #20330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the isFd function to call isUint32 instead of doing the same thing. I was tempted to remove isFd and just use isUint32 instead but wanted to get some feedback from others regarding readablity.
nodejs-github-bot
added
the
fs
BridgeAR
reviewed
Apr 26, 2018
Yeah, I was thinking the same thing (mentioned in the commit message). I'd prefer that. I'll wait a little and if no one objects I'll update. |
|
If you'd like to still call |
I'd like to just use isUint32, but I like what you suggested there if others disagree. Thanks! |
|
I'm +1 on what @tniessen suggested - they do the same thing - but I like the fact |
benjamingr
approved these changes
Apr 26, 2018
TimothyGu
approved these changes
Apr 26, 2018
|
@TimothyGu that function is only used internally as far as I can tell. |
|
Ah oops. In that case LGTM either way. |
richardlau
approved these changes
Apr 26, 2018
TimothyGu
approved these changes
Apr 27, 2018
joyeecheung
approved these changes
Apr 27, 2018
BridgeAR
approved these changes
Apr 27, 2018
BridgeAR
added
fast-track
jasnell
approved these changes
Apr 27, 2018
|
Landed in bdf0d9b 🎉 |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Apr 28, 2018
This commit updates the isFd function to call isUint32 instead of doing the same thing. PR-URL: nodejs#20330 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 4, 2018
This commit updates the isFd function to call isUint32 instead of doing the same thing. PR-URL: #20330 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the isFd function to call isUint32 instead of
doing the same thing. I was tempted to remove isFd and just use isUint32
instead but wanted to get some feedback from others regarding
readablity.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes