Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: make fs.promises non-enumerable #20632

Merged
merged 1 commit into from
May 12, 2018
Merged

Commits on May 12, 2018

  1. fs: make fs.promises non-enumerable

    This prevents the experimental feature warning from being emitted
    in cases where fs.promises is not actually used.
    
    PR-URL: nodejs#20632
    Fixes: nodejs#20504
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    cjihrig committed May 12, 2018
    Configuration menu
    Copy the full SHA
    20509eb View commit details
    Browse the repository at this point in the history