fs: make fs.promises non-enumerable #20632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
fs
targos
approved these changes
May 9, 2018
|
Good idea :-) |
jasnell
approved these changes
May 9, 2018
ljharb
approved these changes
May 9, 2018
ChALkeR
approved these changes
May 9, 2018
joyeecheung
approved these changes
May 9, 2018
ChALkeR
approved these changes
May 9, 2018
test/parallel/test-fs-promises.js
Outdated
| @@ -38,6 +39,8 @@ const tmpDir = tmpdir.path; | |||
|
|
|||
| common.crashOnUnhandledRejection(); | |||
|
|
|||
| assert.strictEqual(Object.keys(fs).includes('promises'), false); | |||
|
|
|||
There was a problem hiding this comment.
A comment noting that this is needed only while and because .promises is experimental might help for future maintenance.
4 tasks
lpinca
approved these changes
May 10, 2018
devsnek
approved these changes
May 10, 2018
TimothyGu
approved these changes
May 11, 2018
Trott
approved these changes
May 11, 2018
|
Tried to do a Linux CI re-run, but it wouldn't restart. node-test-commit-linux has been having odd problems lately and has been failing more than not. /cc @nodejs/build |
danbev
approved these changes
May 11, 2018
Trott
added
the
author ready
This prevents the experimental feature warning from being emitted in cases where fs.promises is not actually used. PR-URL: nodejs#20632 Fixes: nodejs#20504 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 12, 2018
This prevents the experimental feature warning from being emitted in cases where fs.promises is not actually used. PR-URL: #20632 Fixes: #20504 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Merged
10 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the experimental feature warning from being emitted in cases where
fs.promisesis not actually used.Fixes: #20504
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes