Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: mask mode_t type of arguments with 0o777 #20636

Closed
wants to merge 3 commits into from
Closed

lib: mask mode_t type of arguments with 0o777 #20636

wants to merge 3 commits into from

Commits on May 17, 2018

  1. lib: mask mode_t type of arguments with 0o777 

    - Introduce the `validateAndMaskMode` validator that
  validates `mode_t` arguments and mask them with 0o777
  if they are 32-bit unsigned integer or octal string
  to be more consistent with POSIX APIs.
- Use the validator in fs APIs and process.umask for
  consistency.
- Add tests for 32-bit unsigned modes larger than 0o777.
    @joyeecheung
    joyeecheung committed May 17, 2018
    Configuration menu
    Copy the full SHA
    853aac2 View commit details
    Browse the repository at this point in the history

  2. doc: document file mode caveats on Windows 

    - On Windows only the write permission (read-only bit) can be
  manipulated, and there is no distinction among owner, group
  or others.
- mkdir on Windows does not support the mode argument.
    @joyeecheung
    joyeecheung committed May 17, 2018
    Configuration menu
    Copy the full SHA
    6fa590b View commit details
    Browse the repository at this point in the history

  3. fixup! lib: mask mode_t type of arguments with 0o777

    @joyeecheung
    joyeecheung committed May 17, 2018
    Configuration menu
    Copy the full SHA
    37af759 View commit details
    Browse the repository at this point in the history