assert: fix EOL issue in messages on Windows #20754
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
assert
joyeecheung
reviewed
May 16, 2018
| .slice(args[0].start, args[args.length - 1].end) | ||
| .replace(escapeSequencesRegExp, escapeFn); | ||
| if (EOL === '\r\n') { | ||
| message = message.replace(/\r\n/g, '\n'); |
There was a problem hiding this comment.
Maybe I am just bikeshedding, but what if the user deliberately put \r\n in their custom messages?
There was a problem hiding this comment.
This message is not a user message. It is the code that is read and parsed from the file.
There was a problem hiding this comment.
@BridgeAR Oh, didn't look at this close enough, sorry. In that case it should probably be fine.
joyeecheung
approved these changes
May 16, 2018
BridgeAR
added
the
author ready
jasnell
approved these changes
May 16, 2018
trivikr
approved these changes
May 16, 2018
2 tasks
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
May 18, 2018
PR-URL: nodejs#20754 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
|
Landed in 2c42999 |
3 tasks
MylesBorins
pushed a commit
that referenced
this pull request
May 22, 2018
PR-URL: #20754 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My take of #19221. @joyeecheung please feel free to close this PR and just update yours.
I cite @joyeecheung:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes