Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: fix and cleanup constants #20765

Closed
wants to merge 4 commits into from
Closed

fs: fix and cleanup constants #20765

wants to merge 4 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented May 16, 2018

Subset of commits that were originally in #20734

Cleans up some constants usage in fs

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the fs Issues and PRs related to the fs subsystem / file system. label May 16, 2018
@jasnell
Copy link
Member Author

jasnell commented May 16, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/14898/

@jasnell
Copy link
Member Author

jasnell commented May 16, 2018

/cc @nodejs/fs

@joyeecheung joyeecheung added the fast-track PRs that do not need to wait for 48 hours to land. label May 16, 2018
@joyeecheung
Copy link
Member

Please thumbs up this reply if you are +1 to fast-track.

@lpinca lpinca added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 17, 2018
jasnell added a commit that referenced this pull request May 18, 2018
@jasnell
fs: consistent constants use and cleanup
1d3759a 
* only require('buffer') once
* use constants directly
* fix incorrect constants

PR-URL: #20765
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@jasnell
Copy link
Member Author

jasnell commented May 18, 2018

Landed in 1d3759a

@jasnell jasnell closed this May 18, 2018
MylesBorins pushed a commit that referenced this pull request May 22, 2018
@jasnell @MylesBorins
fs: consistent constants use and cleanup
dc30d36 
* only require('buffer') once
* use constants directly
* fix incorrect constants

PR-URL: #20765
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@addaleax addaleax mentioned this pull request May 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbev danbev danbev approved these changes

@ronkorving ronkorving ronkorving approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@jasnell @joyeecheung @danbev @ronkorving @lpinca @targos @cjihrig @BridgeAR @nodejs-github-bot