test: string to template literals, to include port #20889
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test: string to template literals, to include port test: string to template literals, to include port
apapirovski
reviewed
May 22, 2018
| @@ -28,7 +28,7 @@ if (cluster.isMaster) { | |||
|
|
|||
| server.listen({ | |||
| port: 0, | |||
| exclusive: true | |||
| exclusive: true, | |||
There was a problem hiding this comment.
Nit: please remove the comma here since it's an unrelated change. Thanks!
There was a problem hiding this comment.
The comma is still here after the update. As it's not related to this PR, could you please remove it?
| const worker2 = cluster.fork(); | ||
|
|
||
| worker2.on('message', function(port2) { | ||
| assert.strictEqual(port2, port2 | 0, 'second worker could not listen'); | ||
| assert.strictEqual(port2, port2 | 0, `second worker could not listen on port ${port2}`); |
There was a problem hiding this comment.
This will fail the linter, unfortunately. Same above.
You could instead realign like so:
assert.strictEqual(port2, port2 | 0,
`second worker could not listen on port ${port2}`);There was a problem hiding this comment.
The alternative would be to just remove the message altogether and instead show the default error message. That would also be fine with me.
jasnell
approved these changes
May 22, 2018
trivikr
approved these changes
May 22, 2018
lpinca
approved these changes
May 22, 2018
Trott
added
the
author ready
|
Hey guys, do you have some tips for me to make the checks successful, as i was not changing much? |
tniessen
pushed a commit
that referenced
this pull request
May 25, 2018
PR-URL: #20889 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
The failures are unrelated, CI is a bit noisy currently. Landed in 76a1feb, thank you! |
targos
pushed a commit
that referenced
this pull request
May 25, 2018
PR-URL: #20889 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: string to template literals, to include port
Usage of template literals to include the port if strictEqual fails.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes