Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v10.3.0 proposal #21011

Merged
merged 41 commits into from
May 29, 2018
Merged

v10.3.0 proposal #21011

merged 41 commits into from
May 29, 2018

Conversation

MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins commented May 29, 2018 •
edited
Loading

2018-05-29, Version 10.3.0 (Current), @MylesBorins

Notable Changes

  • deps:
    • upgrade npm to 6.1.0 (Rebecca Turner) #20190
  • fs:
    • fix reads with pos > 4GB (Mathias Buus) #21003
  • net:
    • new option to allow IPC servers to be readable and writable by all users (Bartosz Sosnowski) #19472
  • stream:
    • fix removeAllListeners() for Stream.Readable to work as expected when no arguments are passed (Kael Zhang) #20924
  • Added new collaborators

Commits

  • [ea702e2812] - assert: handle undefined filename in getErrMessage (Tim Seckinger) #20848
  • [d7fed22511] - build,win: disable DLL-interface warnings (Bert Belder) #20958
  • [efc7f91354] - deps: cherry-pick 6989b3f6d7 from V8 upstream (Timothy Gu) #20826
  • [d0cdcb61fe] - (SEMVER-MINOR) deps: upgrade npm to 6.1.0 (Rebecca Turner) #20190
  • [ce13797dca] - doc: fix doc for napi_get_typedarray_info (Michael Dawson) #20747
  • [babc9da6f9] - doc: add jdalton to collaborators (John-David Dalton) #20968
  • [f0704f2407] - doc: mark Node 4 as EOL in changelog (Teddy Katz) #20926
  • [87ad9318bb] - doc: update the notable changes (Ruben Bridgewater) #20316
  • [c036cda1f5] - doc: fix outdated link FSEvents (amitbend) #20949
  • [1f3eb1cc1e] - doc: fix filehandle.truncate() sample codes (Masashi Hirano) #20913
  • [819bba6d2b] - doc: removed LTS label from v4 in doc version picker (Chris Young) #20904
  • [be2a467395] - doc: fix incorrect fs.readFileSync example output (Teddy Katz) #20902
  • [bfe6dc369d] - fs: fix reads with pos > 4GB (Mathias Buus) #21003
  • [c2c3b6f434] - lib: use object destructuring for ContextifyScript (Daniel Bevenius) #20934
  • [d2bcd55fb5] - lib: remove unnecessary string interpolation (Daniel Bevenius) #20890
  • [099c6b6c5d] - meta: add link to unofficial discord (Gus Caplan) #20508
  • [45adec2616] - module: name anonymous function for debugging (Nicholas Dangles) #20811
  • [ba30d149ea] - n-api: throw when entry point is null (Gabriel Schulhof) #20779
  • [b242248188] - (SEMVER-MINOR) net: allow IPC servers be accessible by all (Bartosz Sosnowski) #19472
  • [ed9e964357] - net: remove unnecessary variables (chainhelen) #20864
  • [5f9c01b646] - Revert "repl: add friendly tips about how to exit repl" (cjihrig) #20972
  • [902120a927] - src: add CHECK_NULL/CHECK_NOT_NULL macros (Tobias Nießen) #20914
  • [5e69e1a51e] - src: add CHECK_IMPLIES macro (Tobias Nießen) #20914
  • [418739c021] - src: fix MallocedBuffer move assignment operator (Anna Henningsen) #20883
  • [b4519cac20] - src: move DeleteFnPtr into util.h (Anna Henningsen) #20885
  • [b0023d7bc9] - src,doc: add doc of --prof flag to help command (ohbarye) #20845
  • [8f52c3fb6b] - stream: fix removeAllListeners() for Stream.Readable (Kael Zhang) #20924
  • [011235768c] - test: improve assert test hygiene (Rich Trott) #20861
  • [88f9a399d6] - test: isolate unusual assert test in its own file (Rich Trott) #20861
  • [460a5025d0] - test: fix test failure on aix (Ruben Bridgewater) #20940
  • [d09bec8a04] - test: improve error message in async-wrap test (Rich Trott) #20948
  • [460add98fb] - test: reduce runtime (Ruben Bridgewater) #20688
  • [82afb4cf7d] - test: remove message argument from strictEqual() (sagirk) #20912
  • [40e57885d4] - test: remove string literal from strictEqual (AbhimanyuVashisht) #20920
  • [9bbab91479] - test: include port in assertion message (nam) #20889
  • [554ad478d4] - test: improve coverage for readline.Interface (Masashi Hirano) #20704
  • [443d60afcc] - test: use log only in test-child-process-fork-net (Rich Trott) #20873
  • [ed84b7d42f] - test: changed assert message from string literal to template literal (CoreyGMartin) #20870
  • [46e7cec7a5] - tools: fix sorting in doc/type-parser.js (Vse Mozhet Byt) #20976

not-an-aardvark and others added 30 commits May 25, 2018 13:59
@not-an-aardvark @targos
doc: fix incorrect fs.readFileSync example output
be2a467 
This fixes an incorrect example in the documentation for calling
`fs.readFileSync` on a directory. The example was presumably copied from
the documentation for `fs.readFile`, which has an error argument in its
callback.

PR-URL: #20902
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@CoreyGMartin @targos
test: changed assert message from string literal to template literal
ed84b7d 
PR-URL: #20870
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Trott @targos
test: use log only in test-child-process-fork-net
443d60a 
We are currently having issues with test-child-process-fork-net on
Windows CI. Debugging is slightly hampered by the mix of `console.log()`
and `console.error()` as our test runner does not interleave stdout and
stderr, so the order of output is not preserved. Change the sole
instance of `console.error()` to `console.log()` to improve
debugability.

While editing, I also took the opportunity to add capitalization and
punctuation to comments (as that is a nit we see from time to time and
there is a potential ESLint rule to enforce the capitalization part).

PR-URL: #20873
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@chainhelen @targos
net: remove unnecessary variables
ed9e964 
PR-URL: #20864
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@jeysal @targos
assert: handle undefined filename in getErrMessage
ea702e2 
When generating an assertion error message,
`filename` might be undefined,
e.g. if `assert` is called in `eval`.

Handle this case gracefully instead of failing with
`Cannot read property 'endsWith' of undefined`.

Fixes: #20847

PR-URL: #20848
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ohbarye @targos
src,doc: add doc of --prof flag to help command
b0023d7 
Fixes: #16459

PR-URL: #20845
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos
test: improve coverage for readline.Interface
554ad47 
Add tests in parallel/test-readline-interface to increase coverage

PR-URL: #20704
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@devsnek @targos
meta: add link to unofficial discord
099c6b6 
PR-URL: #20508
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos
doc: removed LTS label from v4 in doc version picker
819bba6 
Fixes: #20903

PR-URL: #20904
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos
n-api: throw when entry point is null
ba30d14 
PR-URL: #20779
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@danbev @targos
lib: remove unnecessary string interpolation
d2bcd55 
PR-URL: #20890
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@bzoz @targos
net: allow IPC servers be accessible by all
b242248 
Adds mappings to uv_pipe_chmod call by adding two new options to
listen call. This allows the IPC server pipe to be made readable or
writable by all users.

Fixes: #19154

PR-URL: #19472
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos
doc: fix filehandle.truncate() sample codes
1f3eb1c 
PR-URL: #20913
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@iarna @targos
deps: upgrade npm to 6.1.0
d0cdcb6 
PR-URL: #20190
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos
test: include port in assertion message
9bbab91 
PR-URL: #20889
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@ndangles @targos
module: name anonymous function for debugging
45adec2 
This commit is to help in the effort to name all anonymous
functions to help when heap debugging. The issue asked for
any functions to be updated that are not on a prototype
and this file contains one function that meets those needs.

A previous pull request (13849) was not completed and did
not meet the requirements of the issue so this PR looks
to complete that.

PR-URL: #20811
Refs: #8913
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@addaleax @targos
src: move DeleteFnPtr into util.h
b4519ca 
This is more generally useful than just in a crypto context.

PR-URL: #20885
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@amitbend @targos
doc: fix outdated link FSEvents
c036cda 
PR-URL: #20949
Fixes: #20853
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR @targos
doc: update the notable changes
87ad931 
A couple entries were missing and one entry was not really relevant.

PR-URL: #20316
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@AbhimanyuVashisht @targos
test: remove string literal from strictEqual
40e5788 
Remove obsolete string literals from `assert.strictEqual()` calls in
test/parallel/test-stream-pip-await-drain-push-while-write.js.

PR-URL: #20920
Refs: https://www.nodetodo.org/getting-started
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@sagirk @targos
test: remove message argument from strictEqual()
82afb4c 
In test/parallel/test-require-process.js, the last thing in the test is
a call to assert.strictEqual(). It has a string literal as its third
argument. Unfortunately, that means that the diff between the two values
being compared will be suppressed if there is an AssertionError. That's
not helpful for debugging.

This is fixed by removing the third argument from the call. It is,
however, preserved in a comment above the call to assert.strictEqual().

PR-URL: #20912
Fixes: #20911
Refs: https://www.nodetodo.org/getting-started
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@addaleax @targos
src: fix MallocedBuffer move assignment operator
418739c 
PR-URL: #20883
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@TimothyGu @targos
deps: cherry-pick 6989b3f6d7 from V8 upstream
efc7f91 
Original commit message:
  Fix default Intl language tag handling

  With certain ICU data bundles (such as the Node.js "small-icu"),
  %GetDefaultICULocale() may return a more specific language tag (e.g.
  "en-US") than what's available (e.g. "en"). In those cases, consider the
  more specific language tag supported.

  This CL also resolves the following Node.js issue:
     #15223

  Bug: v8:7024
  Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
  Change-Id: Ifda0776b3418734d5caa8af4e50c17cda95add73
  Reviewed-on: https://chromium-review.googlesource.com/668350
  Commit-Queue: Daniel Ehrenberg <littledan@chromium.org>
  Reviewed-by: Daniel Ehrenberg <littledan@chromium.org>
  Cr-Commit-Position: refs/heads/master@{#52716}

PR-URL: #20826
Fixes: #15223
Refs: v8/v8@6989b3f
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@BridgeAR @MylesBorins
test: reduce runtime
460add9 
This refactors some tests to reduce the runtime of those.

PR-URL: #20688
Refs: #20128
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Yang Guo <yangguo@chromium.org>
@Trott @MylesBorins
test: improve error message in async-wrap test
d09bec8 
Improve AssertionError message in
test/parallel/test-async-wrap-pop-id-during-load.js to include the
contents of stderr when the spawned process fails.

Refs: https://github.com/nodejs/node/pull/20940/files#r190707951

PR-URL: #20948
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@mafintosh @MylesBorins
fs: fix reads with pos > 4GB
bfe6dc3 
PR-URL: #21003
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@tniessen @MylesBorins
src: add CHECK_IMPLIES macro
5e69e1a 
This change introduces the CHECK_IMPLIES macro
similar to its definition in v8 and replaces instances of
CHECK with CHECK_IMPLIES where it seems appropriate.

PR-URL: #20914
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@tniessen @MylesBorins
src: add CHECK_NULL/CHECK_NOT_NULL macros
902120a 
This change introduces CHECK_NULL and CHECK_NOT_NULL macros
similar to their definition in v8 and replaces instances of
CHECK/CHECK_EQ/CHECK_NE with these where it seems appropriate.

PR-URL: #20914
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@not-an-aardvark @MylesBorins
doc: mark Node 4 as EOL in changelog
f0704f2 
Node 4 has been unsupported since 2018-05-01, but the changelog was out
of date and said that Node 4 was still in LTS.

PR-URL: #20926
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
@vsemozhetbyt @MylesBorins
tools: fix sorting in doc/type-parser.js
46e7cec 
This section groups type links by their home modules
and sort these groups alphabetically,
so `modules` types should go before the `net` types.

PR-URL: #20976
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. npm Issues and PRs related to the npm client dependency or the npm registry. v10.x labels May 29, 2018
@MylesBorins
Copy link
Contributor Author

MylesBorins commented May 29, 2018 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/15141/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1445/
CITGM-nobuild: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-nobuild/307/

@mcollina
Copy link
Member

I've added the notable-change label to #20924. It is a bad bug.

mcollina
mcollina approved these changes May 29, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubberstamp LGTM based on the commit list

MylesBorins added a commit that referenced this pull request May 29, 2018
@MylesBorins
2018-05-29, Version 10.3.0 (Current)
b68b1df 
Notable Changes:

* **deps**:
  - upgrade npm to 6.1.0 (Rebecca Turner)
    #20190
* **fs**:
  - fix reads with pos \> 4GB (Mathias Buus)
    #21003
* **net**:
  - new option to allow IPC servers to be readable and writable
    by all users (Bartosz Sosnowski)
    #19472
* **stream**:
  - fix removeAllListeners() for Stream.Readable to work as expected
    when no arguments are passed (Kael Zhang)
    #20924
* **Added new collaborators**
  - John-David Dalton (https://github.com/jdalton)

PR-URL: #21011
@MylesBorins
Copy link
Contributor Author

Windows failure already has a PR open --> #21012

@mafintosh
Copy link
Member

👍 AKA the "You're gonna wanna get this" release.

@devsnek
Copy link
Member

devsnek commented May 29, 2018

I don't know that adding the discord was a notable change in the conventional sense but bumping it up might help give people another option for support.

Trott and others added 2 commits May 29, 2018 18:01
@Trott @MylesBorins
tools: update tools/doc/package-lock.json
b62cbe1 
The package-lock.json file is out of sync with the checked-in
node_modules. `make doc-only` updates package-lock.json appropriately.

PR-URL: #20970
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@MylesBorins
2018-05-29, Version 10.3.0 (Current)
c1dae43 
Notable Changes:

* **deps**:
  - upgrade npm to 6.1.0 (Rebecca Turner)
    #20190
* **fs**:
  - fix reads with pos \> 4GB (Mathias Buus)
    #21003
* **net**:
  - new option to allow IPC servers to be readable and writable
    by all users (Bartosz Sosnowski)
    #19472
* **stream**:
  - fix removeAllListeners() for Stream.Readable to work as expected
    when no arguments are passed (Kael Zhang)
    #20924
* **Added new collaborators**
  - John-David Dalton (https://github.com/jdalton)

PR-URL: #21011
@MylesBorins
Copy link
Contributor Author

Two new failures I don't recognize

parallel/test-trace-events-fs-sync on linuxone
https://ci.nodejs.org/job/node-test-commit-linuxone/1693/

and

parallel/test-util-inspect-namespace on ubuntu1710-x64
https://ci.nodejs.org/job/node-test-commit-linux/19169/nodes=ubuntu1710-x64/

@MylesBorins
Copy link
Contributor Author

Kicking off another CI to be safe

https://ci.nodejs.org/job/node-test-pull-request/15146/

@MylesBorins
Copy link
Contributor Author

Looks like the ubuntu failure is showing up on master as well in https://ci.nodejs.org/job/node-test-commit-linux/nodes=ubuntu1710-x64/19164/

linux one passed this time. Looking into a single citgm failure on ubuntu 1604 (spawn-wrap) and then will promote release

@MylesBorins MylesBorins merged commit c1dae43 into v10.x May 29, 2018
MylesBorins added a commit that referenced this pull request May 29, 2018
@MylesBorins
Working on v10.3.1
471d815 
PR-URL: #21011
MylesBorins added a commit that referenced this pull request May 29, 2018
@MylesBorins
2018-05-29, Version 10.3.0 (Current)
9ae658e 
Notable Changes:

* **deps**:
  - upgrade npm to 6.1.0 (Rebecca Turner)
    #20190
* **fs**:
  - fix reads with pos \> 4GB (Mathias Buus)
    #21003
* **net**:
  - new option to allow IPC servers to be readable and writable
    by all users (Bartosz Sosnowski)
    #19472
* **stream**:
  - fix removeAllListeners() for Stream.Readable to work as expected
    when no arguments are passed (Kael Zhang)
    #20924
* **Added new collaborators**
  - John-David Dalton (https://github.com/jdalton)

PR-URL: #21011
@addaleax addaleax deleted the v10.3.0-proposal branch May 29, 2018 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.