doc: mark Node 4 as EOL in changelog #20926
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
meta
richardlau
reviewed
May 24, 2018
CHANGELOG.md
Outdated
| @@ -29,7 +29,7 @@ release. | |||
| <th><a href="doc/changelogs/CHANGELOG_V9.md">9</a></th> | |||
| <th title="LTS Until 2019-12"><a href="doc/changelogs/CHANGELOG_V8.md">8</a><sup>LTS</sup></th> | |||
| <th title="LTS Until 2019-04"><a href="doc/changelogs/CHANGELOG_V6.md">6</a><sup>LTS</sup></th> | |||
| <th title="LTS Until 2018-04"><a href="doc/changelogs/CHANGELOG_V4.md">4</a><sup>LTS</sup></th> | |||
| <th title="Unsupported Since 2018-05-01"><a href="doc/changelogs/CHANGELOG_V4.md">4</a><sup>EOL</sup></th> | |||
There was a problem hiding this comment.
Maybe End-of-life since 2018-05-01?
There was a problem hiding this comment.
I copied this from the previous text for v0.10/v0.12, but I'm fine with changing it. What do you think?
There was a problem hiding this comment.
Ah didn't spot that. I'd be fine with either.
There was a problem hiding this comment.
I prefer End-of-life since 2018-05-01 but it is also ok this way.
There was a problem hiding this comment.
I updated the message to End-of-life since 2018-05-01.
richardlau
approved these changes
May 24, 2018
lpinca
approved these changes
May 24, 2018
starkwang
approved these changes
May 24, 2018
BridgeAR
approved these changes
May 24, 2018
CHANGELOG.md
Outdated
| @@ -29,7 +29,7 @@ release. | |||
| <th><a href="doc/changelogs/CHANGELOG_V9.md">9</a></th> | |||
| <th title="LTS Until 2019-12"><a href="doc/changelogs/CHANGELOG_V8.md">8</a><sup>LTS</sup></th> | |||
| <th title="LTS Until 2019-04"><a href="doc/changelogs/CHANGELOG_V6.md">6</a><sup>LTS</sup></th> | |||
| <th title="LTS Until 2018-04"><a href="doc/changelogs/CHANGELOG_V4.md">4</a><sup>LTS</sup></th> | |||
| <th title="Unsupported Since 2018-05-01"><a href="doc/changelogs/CHANGELOG_V4.md">4</a><sup>EOL</sup></th> | |||
There was a problem hiding this comment.
I prefer End-of-life since 2018-05-01 but it is also ok this way.
BridgeAR
added
the
author ready
cjihrig
approved these changes
May 24, 2018
Node 4 has been unsupported since 2018-05-01, but the changelog was out of date and said that Node 4 was still in LTS.
not-an-aardvark
force-pushed
the
mark-node-4-eol
branch
from
0ebdc1c
to
1a866ab
Compare
jasnell
approved these changes
May 24, 2018
trivikr
approved these changes
May 25, 2018
XadillaX
approved these changes
May 25, 2018
hiroppy
approved these changes
May 25, 2018
mmarchini
approved these changes
May 26, 2018
|
Landed in 6d3940e |
not-an-aardvark
added a commit
that referenced
this pull request
May 26, 2018
Node 4 has been unsupported since 2018-05-01, but the changelog was out of date and said that Node 4 was still in LTS. PR-URL: #20926 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Matheus Marchini <matheus@sthima.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 29, 2018
Node 4 has been unsupported since 2018-05-01, but the changelog was out of date and said that Node 4 was still in LTS. PR-URL: #20926 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Matheus Marchini <matheus@sthima.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 4 has been unsupported since 2018-05-01, but the changelog was out
of date and said that Node 4 was still in LTS.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes