test: improve path tests #20967
Closed
test: improve path tests #20967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced deepStrictEqual with strictEqual when asserting that the path is equal to the win32 or posix equivalent, since it is a more strict check than deepStrictCheck. Also removed third argument in the check so that if there is an assertion error the properties that are different will be displayed.
cjihrig
approved these changes
May 26, 2018
Trott
approved these changes
May 26, 2018
Trott
added
the
author ready
lpinca
approved these changes
May 26, 2018
ryzokuken
approved these changes
May 26, 2018
BridgeAR
approved these changes
May 26, 2018
trivikr
approved these changes
May 26, 2018
jasnell
approved these changes
May 29, 2018
|
Re-run ARM CI: https://ci.nodejs.org/job/node-test-commit-arm/16507/ Re-run Windows CI: https://ci.nodejs.org/job/node-test-commit-windows-fanned/18401/ |
|
Landed in f49bd39 |
apapirovski
pushed a commit
that referenced
this pull request
Jun 1, 2018
Replaced deepStrictEqual with strictEqual when asserting that the path is equal to the win32 or posix equivalent, since it is a more strict check than deepStrictCheck. Also removed third argument in the check so that if there is an assertion error the properties that are different will be displayed. PR-URL: #20967 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 6, 2018
Replaced deepStrictEqual with strictEqual when asserting that the path is equal to the win32 or posix equivalent, since it is a more strict check than deepStrictCheck. Also removed third argument in the check so that if there is an assertion error the properties that are different will be displayed. PR-URL: #20967 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced deepStrictEqual with strictEqual when asserting that the
path is equal to the win32 or posix equivalent, since it is a more
strict check than deepStrictCheck. Also removed third argument
in the check so that if there is an assertion error the properties
that are different will be displayed.
Note: Credits to Rich Trott from nodetodo.org helping me find this first contribution to work on.
Checklist
make -j4 test(UNIX)Note: One of the tests is crashing right when I clone and run
make -j4 testbefore making any changes. I believe this is specific to my machine and unrelated to this PR:=== release test-zlib.zlib-binding.deflate === Path: async-hooks/test-zlib.zlib-binding.deflate Command: out/Release/node /home/shivang/oss/node/test/async-hooks/test-zlib.zlib-binding.deflate.js --- CRASHED (Signal: 11) ---