Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add jdalton to collaborators #20968

Closed
wants to merge 1 commit into from
Closed

doc: add jdalton to collaborators #20968

wants to merge 1 commit into from

Conversation

jdalton
Copy link
Member

@jdalton jdalton commented May 25, 2018

Fixes: #20828

Checklist

@jdalton jdalton requested a review from a team as a code owner May 25, 2018 18:32
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 25, 2018
@BridgeAR
Copy link
Member

Welcome :-)

@BridgeAR BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label May 25, 2018
@jdalton jdalton changed the title doc: add jddalton to collaborators doc: add jdalton to collaborators May 25, 2018
TimothyGu
TimothyGu approved these changes May 25, 2018
View reviewed changes
Copy link
Member

@TimothyGu TimothyGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉!

ofrobots
ofrobots approved these changes May 25, 2018
View reviewed changes
Copy link
Contributor

@ofrobots ofrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome!

@jdalton
Copy link
Member Author

jdalton commented May 25, 2018

Thank you!

(I currently still need the bits toggled to be able to spin up a CI run and-or merge).

vsemozhetbyt
vsemozhetbyt reviewed May 25, 2018
View reviewed changes
README.md Outdated
@@ -393,6 +393,8 @@ For more information about the governance of the Node.js project, see
* [jasongin](https://github.com/jasongin) -
**Jason Ginchereau** <jasongin@microsoft.com>
* [jbergstroem](https://github.com/jbergstroem) -
**John-David Dalton** <john.david.dalton@gmail.com>
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt May 25, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lines seem to be in the wrong order) Screenshot:

1

@vsemozhetbyt vsemozhetbyt added meta Issues and PRs related to the general management of the project. notable-change PRs with changes that should be highlighted in changelogs. labels May 25, 2018
@addaleax
Copy link
Member

@jdalton Are you being onboarded by somebody at the moment? We usually open these PRs as part of that process – not that there’s anything wrong with this PR, but I think we want to wait with merging it until that occurs?

@addaleax addaleax removed the fast-track PRs that do not need to wait for 48 hours to land. label May 25, 2018
@BridgeAR
Copy link
Member

@addaleax I thought these PRs are always meant to be merged by the onboarded person. If there was no onboarding, that is of course not happening.

@jdalton
Copy link
Member Author

jdalton commented May 25, 2018

We usually open these PRs as part of that process – not that there’s anything wrong with this PR, but I think we want to wait with merging it until that occurs?

That's cool. No one has contacted me yet for onboarding (so I figured I'd get the ball rolling).
I'm fine with waiting for the i's dotted and t's crossed of it all.

@richardlau richardlau added the blocked PRs that are blocked by other issues or PRs. label May 25, 2018
@richardlau
Copy link
Member

I'm going to set blocked just to prevent anyone else merging (although by convention these PRs should only be merged by the onboarded person anyway). Obviously consider it unblocked when the onboarding occurs.

hiroppy
hiroppy approved these changes May 25, 2018
View reviewed changes
Copy link
Member

@hiroppy hiroppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

mcollina
mcollina approved these changes May 26, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott Trott removed the blocked PRs that are blocked by other issues or PRs. label May 28, 2018
@jdalton
Copy link
Member Author

jdalton commented May 28, 2018

ci: https://ci.nodejs.org/job/node-test-pull-request/15121/

@jdalton
Copy link
Member Author

jdalton commented May 28, 2018

Landed in bb6b605

@jdalton jdalton closed this May 28, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request May 28, 2018
@jdalton
doc: add jdalton to collaborators
bb6b605 
PR-URL: nodejs#20968
Fixes: nodejs#20828
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
@jdalton jdalton deleted the jdd branch May 28, 2018 04:43
@gireeshpunathil
Copy link
Member

post-closure LGTM!

@benjamingr
Copy link
Member

Welcome aboard @jdalton !

MylesBorins pushed a commit that referenced this pull request May 29, 2018
@jdalton @MylesBorins
doc: add jdalton to collaborators
babc9da 
PR-URL: #20968
Fixes: #20828
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt left review comments

@mcollina mcollina mcollina approved these changes

@ofrobots ofrobots ofrobots approved these changes

@benjamingr benjamingr benjamingr approved these changes

@Leko Leko Leko approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@tniessen tniessen tniessen approved these changes

@hiroppy hiroppy hiroppy approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nominating jdalton as collaborator