Revert "repl: add friendly tips about how to exit repl" #20972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
approved these changes
May 26, 2018
benjamingr
approved these changes
May 26, 2018
trivikr
approved these changes
May 26, 2018
|
CI: https://ci.nodejs.org/job/node-test-pull-request/15109/ Failures appear unrelated |
BridgeAR
approved these changes
May 28, 2018
BridgeAR
added
the
author ready
jdalton
approved these changes
May 28, 2018
This reverts commit 9aa4ec4. This commit in question introduced a regression in repl.eval(), as the context argument is no longer passed to runInContext(). PR-URL: nodejs#20972 Fixes: nodejs#20965 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 29, 2018
This reverts commit 9aa4ec4. This commit in question introduced a regression in repl.eval(), as the context argument is no longer passed to runInContext(). PR-URL: #20972 Fixes: #20965 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9aa4ec4.
This commit in question introduced a regression in
repl.eval(),as the context argument is no longer passed to
runInContext().Fixes: #20965