doc: document current release procedure #2099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -91,7 +96,7 @@ The _CHANGELOG.md_ entry should take the following form: | |||
| * Include the full list of commits since the last release here | |||
| ``` | |||
|
|
|||
| ### 5. Update _src/node_version.h_ | |||
| ### 4. Update _src/node_version.h_ | |||
There was a problem hiding this comment.
I know this is a tiny thing, but we should probably make a script for it. I know I've definitely messed this up in subtle ways before.
There was a problem hiding this comment.
agreed, and I messed up the tag comment for 2.3.3 today as well, this could either be Jenkinsised or put into a script but I don't see an obvious path yet
|
so much feedback, thanks folks, pushed a new version, ptal |
| _TODO: Update doc with announce procedure when we figure this out._ | ||
| The iojs.org website will automatically rebuild and include the new version. You simply need to announce the build, preferably via twitter with a message such as: | ||
|
|
||
| > v2.3.2 of @official_iojs is out @ https://iojs.org/dist/latest/ changelog @ https://github.com/nodejs/io.js/blob/master/CHANGELOG.md#2015-07-01-version-232-rvagg … something here about notable changes |
There was a problem hiding this comment.
latest/ changelog has two spaces.
|
LGTM minus one nit |
PR-URL: nodejs#2099 Author: Jeremiah Senkpiel <fishrock123@rocketmail.com>
|
84b3915 merged, thanks folks |
mscdex
pushed a commit
to mscdex/io.js
that referenced
this pull request
Jul 9, 2015
PR-URL: nodejs#2099 Author: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/R=@Fishrock123 @chrisdickinson