test: reduce benchmark runs in tests #21032
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add option to test-benchmark-timers such that all benchmark files return only a single set of results. (This helps prevent benchmark tests from taking a long time to run.) Alphabetize options in the file.
Prevent crypto benchmark files from running more than one benchmark during tests.
nodejs-github-bot
added
benchmark
jasnell
approved these changes
May 30, 2018
Trott
added
author ready
|
👍 here for fast-tracking. |
2 tasks
apapirovski
approved these changes
May 31, 2018
|
Re-running three unrelated CI failures. CI is in a better place now than it was 3 days ago... https://ci.nodejs.org/job/node-test-commit-freebsd/18206/ |
|
Windows re-run again: https://ci.nodejs.org/job/node-test-commit-windows-fanned/18460/ |
|
Windows re-run but this time rebasing against master (hopefully I did that right) so that we get the problematic test marked as flaky (so we get yellow instead of red in CI): https://ci.nodejs.org/job/node-test-commit-windows-fanned/18461/ |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jun 2, 2018
Add option to test-benchmark-timers such that all benchmark files return only a single set of results. (This helps prevent benchmark tests from taking a long time to run.) Alphabetize options in the file. PR-URL: nodejs#21032 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jun 2, 2018
Prevent crypto benchmark files from running more than one benchmark during tests. PR-URL: nodejs#21032 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
|
Landed in 77d3f14...6168959 |
MylesBorins
pushed a commit
that referenced
this pull request
Jun 6, 2018
Add option to test-benchmark-timers such that all benchmark files return only a single set of results. (This helps prevent benchmark tests from taking a long time to run.) Alphabetize options in the file. PR-URL: #21032 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 6, 2018
Prevent crypto benchmark files from running more than one benchmark during tests. PR-URL: #21032 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes