-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: reduce benchmark runs in tests #21032
Conversation
Add option to test-benchmark-timers such that all benchmark files return only a single set of results. (This helps prevent benchmark tests from taking a long time to run.) Alphabetize options in the file.
Prevent crypto benchmark files from running more than one benchmark during tests.
👍 here for fast-tracking. |
Re-running three unrelated CI failures. CI is in a better place now than it was 3 days ago... https://ci.nodejs.org/job/node-test-commit-freebsd/18206/ |
Windows re-run again: https://ci.nodejs.org/job/node-test-commit-windows-fanned/18460/ |
Windows re-run but this time rebasing against master (hopefully I did that right) so that we get the problematic test marked as flaky (so we get yellow instead of red in CI): https://ci.nodejs.org/job/node-test-commit-windows-fanned/18461/ |
Add option to test-benchmark-timers such that all benchmark files return only a single set of results. (This helps prevent benchmark tests from taking a long time to run.) Alphabetize options in the file. PR-URL: nodejs#21032 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Prevent crypto benchmark files from running more than one benchmark during tests. PR-URL: nodejs#21032 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Landed in 77d3f14...6168959 |
Add option to test-benchmark-timers such that all benchmark files return only a single set of results. (This helps prevent benchmark tests from taking a long time to run.) Alphabetize options in the file. PR-URL: #21032 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Prevent crypto benchmark files from running more than one benchmark during tests. PR-URL: #21032 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes