Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: minor adjustments to test-http2-respond-file #21098

Closed
wants to merge 1 commit into from
Closed

test: minor adjustments to test-http2-respond-file #21098

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Jun 2, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 2, 2018
@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 2, 2018
@addaleax
Copy link
Member Author

addaleax commented Jun 2, 2018

CI: https://ci.nodejs.org/job/node-test-commit/18949/

Please 👍 this comment to approve fast-tracking.

@addaleax addaleax added the http2 Issues or PRs related to the http2 subsystem. label Jun 2, 2018
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 2, 2018
@addaleax
Copy link
Member Author

addaleax commented Jun 2, 2018

Landed in 65b17d4

@addaleax addaleax closed this Jun 2, 2018
@addaleax addaleax deleted the refactor-respond-file branch June 2, 2018 15:04
addaleax added a commit that referenced this pull request Jun 2, 2018
@addaleax
test: minor adjustments to test-http2-respond-file
65b17d4 
PR-URL: #21098
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit that referenced this pull request Jun 6, 2018
@addaleax @MylesBorins
test: minor adjustments to test-http2-respond-file
bd0d19d 
PR-URL: #21098
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Jun 6, 2018
Merged
kjin pushed a commit to kjin/node that referenced this pull request Aug 23, 2018
@addaleax @kjin
test: minor adjustments to test-http2-respond-file
9be7f75 
PR-URL: nodejs#21098
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
kjin pushed a commit to kjin/node that referenced this pull request Sep 25, 2018
@addaleax @kjin
test: minor adjustments to test-http2-respond-file
ea85d3a 
PR-URL: nodejs#21098
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
kjin pushed a commit to kjin/node that referenced this pull request Oct 16, 2018
@addaleax @kjin
test: minor adjustments to test-http2-respond-file
b53a753 
PR-URL: nodejs#21098
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BethGriggs pushed a commit that referenced this pull request Oct 17, 2018
@addaleax @BethGriggs
test: minor adjustments to test-http2-respond-file
322f39d 
Backport-PR-URL: #22850
PR-URL: #21098
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Oct 30, 2018
Merged
@beevelop beevelop mentioned this pull request Nov 20, 2018
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 18, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apapirovski apapirovski apapirovski approved these changes

@Trott Trott Trott approved these changes

@maclover7 maclover7 maclover7 approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. http2 Issues or PRs related to the http2 subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@addaleax @apapirovski @Trott @maclover7 @richardlau @nodejs-github-bot