Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: patch V8 to 6.7.288.45 #21192

Closed
wants to merge 1 commit into from
Closed

deps: patch V8 to 6.7.288.45 #21192

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Jun 7, 2018

Refs: v8/v8@6.7.288.44...6.7.288.45

Comment from the revert:

This is a short-term fix for NodeJS regression caused by Scavenger
not collecting weak handles that are marked as independent.

@nodejs/v8-update @ofrobots

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Jun 7, 2018
@targos
Copy link
Member Author

targos commented Jun 7, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/15322/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1409/

ofrobots
ofrobots approved these changes Jun 7, 2018
View reviewed changes
Copy link
Contributor

@ofrobots ofrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM – thanks for being so quick to pick this up!

targos added a commit to targos/node that referenced this pull request Jun 10, 2018
@targos
deps: patch V8 to 6.7.288.45
473e36d 
Refs: v8/v8@6.7.288.44...6.7.288.45

PR-URL: nodejs#21192
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos
Copy link
Member Author

targos commented Jun 10, 2018

Landed in 473e36d

@targos targos closed this Jun 10, 2018
@targos targos deleted the v8-6.7.288.45 branch June 10, 2018 09:56
targos added a commit that referenced this pull request Jun 10, 2018
@targos
deps: patch V8 to 6.7.288.45
02b4047 
Refs: v8/v8@6.7.288.44...6.7.288.45

PR-URL: #21192
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofrobots ofrobots ofrobots approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@targos @ofrobots @jasnell @nodejs-github-bot