-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
win, build: fix building on 32-bit machines #21437
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
approved these changes
Jun 21, 2018
refack
approved these changes
Jun 21, 2018
3 tasks
jasnell
approved these changes
Jun 21, 2018
addaleax
approved these changes
Jun 22, 2018
Landed in 43a2091 |
Merged
refack
added a commit
to refack/node
that referenced
this pull request
Aug 16, 2018
Since we are CI testing on x64 hosts, we can only commit to x64 hosts. PR-URL: nodejs#21443 Refs: nodejs#21402 Refs: nodejs#21437 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matheus Marchini <matheus@sthima.com> Reviewed-By: João Reis <reis@janeasystems.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
build
Issues and PRs related to build files or the CI.
fast-track
PRs that do not need to wait for 48 hours to land.
windows
Issues and PRs related to the Windows platform.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #21402
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes/cc @nodejs/build-files @nodejs/platform-windows