Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add codebytere as collaborator #21700

Closed
wants to merge 1 commit into from
Closed

doc: add codebytere as collaborator #21700

wants to merge 1 commit into from

Conversation

codebytere
Copy link
Member

This PR adds myself, @codebytere, to the Collaborators list following onboarding.

Checklist
  • make -j4 test passes
  • documentation is changed or added
  • commit message follows commit guidelines

@codebytere codebytere added doc Issues and PRs related to the documentations. notable-change PRs with changes that should be highlighted in changelogs. labels Jul 7, 2018
@nodejs-github-bot
Copy link
Collaborator

@codebytere build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/220/pipeline

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 7, 2018
Trott
Trott approved these changes Jul 7, 2018
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@codebytere
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request-lite/903/

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 7, 2018
@codebytere
Copy link
Member Author

Landed in b794d37

@codebytere codebytere closed this Jul 7, 2018
codebytere added a commit that referenced this pull request Jul 7, 2018
@codebytere
doc: add codebytere as collaborator
b794d37 
PR-URL: #21700
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
@codebytere codebytere deleted the add-codebytere branch July 7, 2018 20:54
targos pushed a commit that referenced this pull request Jul 8, 2018
@codebytere @targos
doc: add codebytere as collaborator
e532602 
PR-URL: #21700
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
targos pushed a commit that referenced this pull request Jul 9, 2018
@codebytere @targos
doc: add codebytere as collaborator
9716793 
PR-URL: #21700
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
@maclover7 maclover7 mentioned this pull request Jul 12, 2018
Closed
@targos targos mentioned this pull request Jul 17, 2018
Merged
This was referenced Jul 18, 2018
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apapirovski apapirovski apapirovski approved these changes

@bengl bengl bengl approved these changes

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@codebytere @nodejs-github-bot @apapirovski @bengl @Trott @cjihrig