Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: run ESM tests in parallel #21919

Closed
wants to merge 1 commit into from
Closed

Conversation

targos
Copy link
Member

@targos targos commented Jul 21, 2018

This reduces make jstest runs by 4-5 seconds on my machine (12 cores)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@targos targos added the test Issues and PRs related to the tests. label Jul 21, 2018
@Trott
Copy link
Member

Trott commented Jul 21, 2018

Stress test to make sure none of these are likely to be unreliable when run in parallel: https://ci.nodejs.org/job/node-stress-single-test/1968/nodes=osx1010/console

@Trott
Copy link
Member

Trott commented Jul 22, 2018

These tests occasionally get hung up in the stress test, suggesting that they might end up being flaky/unreliable, although they also might not. I'm unable to reproduce locally.

Not objecting to this landing, but wouldn't discourage anyone from investigating further if they were so inclined.

@maclover7
Copy link
Contributor

@targos
Copy link
Member Author

targos commented Aug 4, 2018

Landed in 34fb560

@targos targos closed this Aug 4, 2018
@targos targos deleted the esm-parallel branch August 4, 2018 16:20
targos added a commit that referenced this pull request Aug 4, 2018
PR-URL: #21919
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos added a commit that referenced this pull request Aug 4, 2018
PR-URL: #21919
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants