Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: do not advise to cancel full CI on onboarding #21977

Closed
wants to merge 1 commit into from
Closed

doc: do not advise to cancel full CI on onboarding #21977

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Refs: #21938 (comment) and discussion below the comment.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 25, 2018
@vsemozhetbyt vsemozhetbyt added the meta Issues and PRs related to the general management of the project. label Jul 25, 2018
@vsemozhetbyt
Copy link
Contributor Author

Should we cc and label TSC for this?

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 25, 2018
@maclover7
Copy link
Contributor

cc @Trott

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 26, 2018
@Trott
Copy link
Member

Trott commented Jul 26, 2018

👍 this comment to fast-track.

@vsemozhetbyt
Copy link
Contributor Author

Landed in a9f32a3
Thank you for the reviews.

@vsemozhetbyt vsemozhetbyt deleted the doc-no-ci-aborting branch July 26, 2018 15:02
vsemozhetbyt added a commit that referenced this pull request Jul 26, 2018
Refs: #21938 (comment)
and discussion below the comment.

PR-URL: #21977
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
targos pushed a commit that referenced this pull request Jul 26, 2018
Refs: #21938 (comment)
and discussion below the comment.

PR-URL: #21977
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@targos targos mentioned this pull request Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants